-
Notifications
You must be signed in to change notification settings - Fork 1.8k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Explicitly disable sparse checkout unless asked for #1598
Merged
jww3
merged 36 commits into
actions:main
from
dscho:explicitly-disable-sparse-checkout-unless-asked-for
Feb 21, 2024
Merged
Changes from 3 commits
Commits
Show all changes
36 commits
Select commit
Hold shift + click to select a range
5adf77f
If no `sparse-checkout` parameter is specified, disable it
dscho c4cda12
npm run build
dscho 6f108b2
ci: verify that an existing sparse checkout can be made unsparse
dscho 6d74269
Prefer ubuntu over alpine in test-proxy workflow
jww3 4dfc3ce
revert change to container image in test.yml
jww3 463d088
Bump actions/checkout version in `test-proxy`
jww3 ed56252
prefer ununtu over alpine in `test-proxy`
jww3 268a122
Temporarily disable failing test.
jww3 b300d42
Inspect git version during `test-proxy`
jww3 9b4fb8b
fix order-of-operations in test.yml
jww3 9397c07
Fix order-of-operations in test.yml
jww3 3940af5
Ensure `test-proxy` is using an up-to-date version of git
jww3 572f5de
Experiment on `test-proxy`
jww3 78c6190
Create ubuntu-with-git.Dockerfile
jww3 a48123a
Rename ubuntu-with-git.Dockerfile to Dockerfile
jww3 34a3ecd
Create ubuntu-with-git/action.yml
jww3 6af92d2
Delete .github/ubuntu-with-git directory
jww3 894f97f
Removed commented-out docker commands in test.yml
jww3 996d145
Second attempt to install git via `apt-get`
jww3 87e9846
Followed official guidance for installing git
jww3 772739e
ensure `software-properties-common` is installed.
jww3 97826d9
Tweaked `apt` commands
jww3 eb87b7a
Tweaked `apt` commands
jww3 d5b8261
Upgrade `apt-get`
jww3 2349742
Try disabling `https_proxy` while git installs.
jww3 28a19e1
Update test.yml
jww3 82808ae
Update test.yml
jww3 365131c
Update test.yml
jww3 e7b6c8e
Update test.yml
jww3 9af61b0
Update test.yml
jww3 7aa0640
Determine path to git runtime
jww3 159fd98
Try mapping git runtime into container
jww3 5ecc8b5
Update test.yml
jww3 f0ae198
Update test.yml
jww3 bbd0474
Update test.yml
jww3 4d1347d
`test-proxy` now uses newly-minted `test-ubuntu-git` container image …
jww3 File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
do you want to pop the
.startGroup
/.endGroup
calls outside of theif
block?Consider
core.startGroup('Applying sparse checkout options');
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
No, because we're not actually setting up a sparse checkout. We're disabling it. But saying that would only make sense if there was a worktree already, otherwise there'd be no sparse checkout to disable.