convert SSH URL to HTTPS #179
Conversation
|
@m-hilgendorf can you try this branch I think it should work for you with the change in this PR. |
|
@m-hilgendorf sorry i just saw your comment on the other issue... Since you are using private submodules, you would need to also specify the |
|
Thank you! Sorry for the trouble. This PR does remove the need for the |
ericsciple
force-pushed
the
users/ericsciple/m167instead_impl
branch
from
0c0c1a1 to
71151be
Compare
| @@ -35,7 +35,7 @@ jobs: | |||
| uses: actions/checkout@v2 | |||
|
|
|||
| # Basic checkout | |||
| - name: Basic checkout | |||
| - name: Checkout basic | |||
There was a problem hiding this comment.
Check status reads better like this - skim easier since lines up with Verify ___ steps
| uses: ./ | ||
| with: | ||
| ref: test-data/v2/submodule | ||
| ref: test-data/v2/submodule-ssh-url |
There was a problem hiding this comment.
This E2E tests the behavior url.https://github.com/.insteadOf git@github.com:
| yield this.configureToken(newGitConfigPath, true); | ||
| // Configure HTTPS instead of SSH |
There was a problem hiding this comment.
during the submodule update
| `git config --local "${this.insteadOfKey}" "${this.insteadOfValue}"`, | ||
| `git config --local --show-origin --name-only --get-regexp remote.origin.url` | ||
| ]; | ||
| const output = yield this.git.submoduleForeach(commands.join(' && '), this.settings.nestedSubmodules); |
There was a problem hiding this comment.
when persisting creds for submodules
| const output = yield this.git.submoduleForeach(`git config "${this.tokenConfigKey}" "${this.tokenPlaceholderConfigValue}" && git config --local --show-origin --name-only --get-regexp remote.origin.url`, this.settings.nestedSubmodules); | ||
| const commands = [ | ||
| `git config --local "${this.tokenConfigKey}" "${this.tokenPlaceholderConfigValue}"`, | ||
| `git config --local "${this.insteadOfKey}" "${this.insteadOfValue}"`, |
There was a problem hiding this comment.
the diff is hard to read here, but basically the git config insteadOf is new
| @@ -114,8 +122,13 @@ class GitAuthHelper { | |||
| // Configure a placeholder value. This approach avoids the credential being captured | |||
| // by process creation audit events, which are commonly logged. For more information, | |||
| // refer to https://docs.microsoft.com/en-us/windows-server/identity/ad-ds/manage/component-updates/command-line-process-auditing | |||
| const commands = [ | |||
| `git config --local "${this.tokenConfigKey}" "${this.tokenPlaceholderConfigValue}"`, | |||
|
related to #116 |
related to ADR #178