Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Invalid Releases #31

Closed
dsanders11 opened this issue Aug 27, 2023 · 3 comments · Fixed by #33
Closed

Invalid Releases #31

dsanders11 opened this issue Aug 27, 2023 · 3 comments · Fixed by #33
Assignees
@gr2m
Labels
released

Comments

@dsanders11
Copy link
Contributor

dsanders11 commented Aug 27, 2023 •
edited
Loading

This action has multiple tagged versions, but dist/ has never been updated, so all of the versions are identical.

The action template repos have a workflow to detect this situation: https://github.com/actions/javascript-action/blob/main/.github/workflows/check-dist.yml
@gr2m
Copy link
Contributor

gr2m commented Aug 28, 2023

we have automation in place to update the dist/ file but recently changed it, looks like the new automation is not working, I'll look into it

@gr2m gr2m self-assigned this Aug 28, 2023
@parkerbxyz parkerbxyz mentioned this issue Aug 28, 2023
Merged
@parkerbxyz
Copy link
Contributor

parkerbxyz commented Aug 28, 2023 •
edited
Loading

Fixed by #33.

@parkerbxyz
Copy link
Contributor

Thanks for noticing and reporting this, @dsanders11! ✨

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@gr2m gr2m

Labels
released
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

fix(release): build dist/ before release actions/create-github-app-token
3 participants
@gr2m @dsanders11 @parkerbxyz