Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat: support tokens scoped to multiple repositories within organization #46
feat: support tokens scoped to multiple repositories within organization #46
Changes from 16 commits
12bf248
9c2fe6b
4e0d015
151c72e
84c746a
98d3657
63a98a7
8f5a382
a12bbe4
fb1cbf7
c21d2ca
6d39deb
90239ca
3cfbd0e
e8a138f
7c7676d
4b133dc
68894b6
02c936f
73f98bd
91b880c
80484a9
aa7595e
2df34b8
13b24f0
9dcf16e
dad2c36
0a057cb
7c0311c
File filter
Filter by extension
Conversations
Jump to
There are no files selected for viewing
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
org
is always empty here if owner2 is passed to this functionThere was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
The
dist/*
files are compiled build files. Better comment on themain.js
andlib/main.js
I think that my PR here addresses your concern timreimherr#1
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This was an issue I ran into when trying to use your fork as an action. It might be that the dist file wasn't up to date at the time I made the comment, I just assumed it would be.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
ah makes sense, thank you for clarifying
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
if we need to get the installation ID for the current owner, we should keep doing it using
GET /repos/{owner}/{repo}/installation
. Because if the owner is set to something else, we need to check two endpoints, because the owner can be either an org or a user:There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
See my suggested change at timreimherr#1