Skip to content
This repository has been archived by the owner on Mar 4, 2021. It is now read-only.

Bump actions/github to 2.2.0 #70

Merged
merged 1 commit into from
May 15, 2020
Merged

Bump actions/github to 2.2.0 #70

merged 1 commit into from
May 15, 2020

Conversation

pjquirk
Copy link
Contributor

@pjquirk pjquirk commented May 12, 2020

This adds support for running against GHES by using v2.2.0 of @actions/github. The details of connecting to a GHES instance or github.com are handled internally in the client, so no code changes in this action are necessary.

Tested by pushing this version of the action to an "actions" org on the GHES instance. I also needed to set NODE_TLS_REJECT_UNAUTHORIZED = 0 temporarily in the action to get around my self-signed (or otherwise not trusted) server cert.

@pjquirk pjquirk requested a review from IAmHughes May 12, 2020 20:40
@pjquirk
Copy link
Contributor Author

pjquirk commented May 12, 2020

After this, we'll need to move the release tag forward to pick up this change for existing workflows.

Copy link
Contributor

@IAmHughes IAmHughes left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Glad to hear its coming to GHES!

@pjquirk pjquirk merged commit c9ba696 into master May 15, 2020
@pjquirk pjquirk deleted the users/paquirk/ghesfixes branch May 15, 2020 19:20
@pjquirk
Copy link
Contributor Author

pjquirk commented May 15, 2020

We'll also need to move the v1 tag forward to include this change. @IAmHughes I can do that (I think I have permissions) unless you want to wait (if there's a new minor release coming shortly).

@IAmHughes
Copy link
Contributor

@pjquirk I say go for it!

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants