-
Notifications
You must be signed in to change notification settings - Fork 78
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Deploy pages using artifact IDs #251
Merged
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Remove "beta" disclaimer from README
TooManyBees
approved these changes
Oct 30, 2023
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks good. Though let's make a compatible PR for the API before merging this.
End to End deployment with artifacts V4 now works! We can merge this in 😃 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes: https://github.com/github/actions-results-team/issues/1988
Currently deployments are made using and
artifact_url
. This is done so that internally we call APIs while a run is still in-progress which is a big limitation with the current v1-v3 artifact actions. With the upcoming v4 artifact actions as soon as an artifact is uploaded then it is immediately available from the Artifacts API. The public API will allow us to work with artifact IDs which are much cleaner then working with aartifact_url
.As part of the changes I did the following
getArtifactMetadata
method that fetches artifacts for a workflow run given a run ID and nameartifact_url
See this example run: https://github.com/bbq-beets/testing-artifacts-v4/actions/runs/6697548931/job/18197689133
It fails as expected because the code downstream in the API is not ready to handle an
artifact_id
. This is being worked on now in a subsequent PR internally.