Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Deploy pages using artifact IDs #251

Merged
merged 17 commits into from
Nov 3, 2023
Merged

Conversation

konradpabjan
Copy link
Contributor

@konradpabjan konradpabjan commented Oct 30, 2023

Closes: https://github.com/github/actions-results-team/issues/1988

Currently deployments are made using and artifact_url. This is done so that internally we call APIs while a run is still in-progress which is a big limitation with the current v1-v3 artifact actions. With the upcoming v4 artifact actions as soon as an artifact is uploaded then it is immediately available from the Artifacts API. The public API will allow us to work with artifact IDs which are much cleaner then working with a artifact_url.

As part of the changes I did the following

  • Add a new getArtifactMetadata method that fetches artifacts for a workflow run given a run ID and name
  • Remove all the old code that dealt with fetching the current artifact_url
  • Remove 3 packages that are no longer needed
  • Update all the existing tests
  • Add some new tests specific for artifacts

See this example run: https://github.com/bbq-beets/testing-artifacts-v4/actions/runs/6697548931/job/18197689133

image

It fails as expected because the code downstream in the API is not ready to handle an artifact_id. This is being worked on now in a subsequent PR internally.

@konradpabjan konradpabjan marked this pull request as ready for review October 30, 2023 19:15
@konradpabjan konradpabjan requested a review from a team as a code owner October 30, 2023 19:15
Copy link
Contributor

@TooManyBees TooManyBees left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good. Though let's make a compatible PR for the API before merging this.

@konradpabjan
Copy link
Contributor Author

End to End deployment with artifacts V4 now works! We can merge this in 😃

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants