Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Use the Actions artifacts client to avoid needing the actions: read permission #288

Merged
merged 19 commits into from
Dec 22, 2023
Merged

Use the Actions artifacts client to avoid needing the actions: read permission #288

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
19 commits
Select commit Hold shift + click to select a range
81251b5
Use the Actions artifacts client to avoid needing the actions-read pe…
JamesMGreene Dec 19, 2023
af9eaca
Merge branch 'main' into use-artifacts-client
JamesMGreene Dec 20, 2023
0486580
Set the right env variables to get artifacts client to initialize
TooManyBees Dec 21, 2023
4be3403
Fix *most* tests
TooManyBees Dec 21, 2023
340b369
Correct size field in response payload
TooManyBees Dec 21, 2023
e386446
Catch artifact-client errors differently from octokit errors
TooManyBees Dec 22, 2023
88807a7
Fix formatting
JamesMGreene Dec 22, 2023
02cb90e
Update distributables
JamesMGreene Dec 22, 2023
c704b8a
Remove 'total_count' from fake responses in tests
JamesMGreene Dec 22, 2023
72ab981
Wrap Twirp responses like Octokit responses for consistency
JamesMGreene Dec 22, 2023
b3879ba
Update tests
JamesMGreene Dec 22, 2023
fe3d75d
Update distributables
JamesMGreene Dec 22, 2023
1c0b543
Remove 'actions: read' permissions from README
JamesMGreene Dec 22, 2023
ed0e794
Minimizing unnecessary differences
JamesMGreene Dec 22, 2023
013b725
Oxford commas
JamesMGreene Dec 22, 2023
d6fbcf8
Log the more raw error message from Twirp
JamesMGreene Dec 22, 2023
e03d00b
Update distributables
JamesMGreene Dec 22, 2023
5cba2b1
Display artifact name in some post-filter error messages
JamesMGreene Dec 22, 2023
35a0f06
Add empty request body for more completeness
JamesMGreene Dec 22, 2023
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 0 additions & 2 deletions README.md
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -30,7 +30,6 @@ jobs:
permissions:
pages: write # to deploy to Pages
id-token: write # to verify the deployment originates from an appropriate source
actions: read # to download an artifact uploaded by `actions/upload-pages-artifact@v3`

# Deploy to the github-pages environment
environment:
Expand Down Expand Up @@ -77,7 +76,6 @@ There are a few important considerations to be aware of:
2. The job that executes the deployment must at minimum have the following permissions:
- `pages: write`
- `id-token: write`
- `actions: read`

3. The deployment should target the `github-pages` environment (you may use a different environment name if needed, but this is not recommended.)

Expand Down
2 changes: 1 addition & 1 deletion coverage_badge.svg
View file
Open in desktop
Loading
Sorry, something went wrong. Reload?
Sorry, we cannot display this file.
Sorry, this file is invalid so it cannot be displayed.
178,329 changes: 136,869 additions & 41,460 deletions dist/index.js
View file
Open in desktop

Large diffs are not rendered by default.

2 changes: 1 addition & 1 deletion dist/index.js.map
View file
Open in desktop

Large diffs are not rendered by default.

2,802 changes: 2,784 additions & 18 deletions dist/licenses.txt
View file
Open in desktop

Large diffs are not rendered by default.

Loading