[Error message] add file permissions in message #336
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Its-Just-Nans
changed the title
Its-Just-Nans
changed the title
There was a problem hiding this comment.
This is actually caused by a regression on the Pages backend, as we should be returning the deployments_perms_error code instead of the deployment_content_failed code if it is permissions related.
I'll see about getting that corrected in the appropriate place. 👀
|
Pages deployments on github.com won't fail based on file permissions anymore. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Hi
I had an error with file permissions (exactly this one #303 (comment))
I think we can add the file permissions message to users
to
Related to:
file permissionsexplained in https://github.com/actions/upload-pages-artifact/blob/main/README.md