Update default runtime to node16 #235
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Node 12 has an end of life on April 30, 2022. This PR updates the default runtime to [node16](https://github.blog/changelog/2021-12-10-github-actions-github-hosted-runners-now-run-node-js-16-by-default/), rather then node12. This is supported on all Actions Runners v2.285.0 or later.
|
Looks good to me. cc @joshmgross do you think this warrants a major version bump of the action itself? e.g. out-dated self-hosted runners, etc. |
|
This is effectively a breaking change as we'll now be running users' scripts with Node 16 instead of Node 12, so it will require a major version update. If we're bumping the major version, I'd love to see if we can fit #168 into that release. |
joshmgross
approved these changes
Feb 9, 2022
This was referenced Feb 9, 2022
34 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Node 12 has an end of life on April 30, 2022.
This PR updates the default runtime to node16, rather then node12.
This is supported on all Actions Runners v2.285.0 or later.