-
Notifications
You must be signed in to change notification settings - Fork 444
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add node-fetch #321
Add node-fetch #321
Conversation
Looks like the |
Actually that's failing on |
Thanks for your contribution! I'll go ahead and release a new version with this |
This is now available in https://github.com/actions/github-script/releases/tag/v6.4.0 I'll update |
[](https://renovatebot.com) This PR contains the following updates: | Package | Type | Update | Change | |---|---|---|---| | [actions/github-script](https://togithub.com/actions/github-script) | action | minor | `v6.3.3` -> `v6.4.0` | --- ### Release Notes <details> <summary>actions/github-script</summary> ### [`v6.4.0`](https://togithub.com/actions/github-script/releases/tag/v6.4.0) [Compare Source](https://togithub.com/actions/github-script/compare/v6.3.3...v6.4.0) ##### What's Changed - Bump json5 from 2.1.3 to 2.2.3 by [@​dependabot](https://togithub.com/dependabot) in [https://github.com/actions/github-script/pull/319](https://togithub.com/actions/github-script/pull/319) - Bump minimatch from 3.0.4 to 3.1.2 by [@​dependabot](https://togithub.com/dependabot) in [https://github.com/actions/github-script/pull/320](https://togithub.com/actions/github-script/pull/320) - Add node-fetch by [@​danmichaelo](https://togithub.com/danmichaelo) in [https://github.com/actions/github-script/pull/321](https://togithub.com/actions/github-script/pull/321) ##### New Contributors - [@​jongwooo](https://togithub.com/jongwooo) made their first contribution in [https://github.com/actions/github-script/pull/313](https://togithub.com/actions/github-script/pull/313) - [@​austinvazquez](https://togithub.com/austinvazquez) made their first contribution in [https://github.com/actions/github-script/pull/306](https://togithub.com/actions/github-script/pull/306) - [@​danmichaelo](https://togithub.com/danmichaelo) made their first contribution in [https://github.com/actions/github-script/pull/321](https://togithub.com/actions/github-script/pull/321) **Full Changelog**: actions/github-script@v6.3.3...v6.4.0 </details> --- ### Configuration 📅 **Schedule**: Branch creation - At any time (no schedule defined), Automerge - At any time (no schedule defined). 🚦 **Automerge**: Disabled by config. Please merge this manually once you are satisfied. ♻ **Rebasing**: Whenever PR becomes conflicted, or you tick the rebase/retry checkbox. 🔕 **Ignore**: Close this PR and you won't be reminded about this update again. --- - [ ] <!-- rebase-check -->If you want to rebase/retry this PR, check this box --- This PR has been generated by [Mend Renovate](https://www.mend.io/free-developer-tools/renovate/). View repository job log [here](https://app.renovatebot.com/dashboard#github/JellyfishSDK/jellyfish). <!--renovate-debug:eyJjcmVhdGVkSW5WZXIiOiIzNC4xMTEuMSIsInVwZGF0ZWRJblZlciI6IjM0LjExMS4xIn0=--> Co-authored-by: renovate[bot] <29139614+renovate[bot]@users.noreply.github.com>
Fixes #305
Installed node-fetch 2.6.7, which is the same version used by
@octokit/request
:The bundle size only increased from 772,787 to 772,991 bytes, so seems like re-use works well.
If we installed node-fetch 3 instead, the bundle size would increase to 1,045,047 bytes. Most likely the difference would hardly be noticeable, but on the other hand there aren't that many important improvements in node-fetch 3 as far as I'm aware, so perhaps it's still better to use node-fetch 2 to save 270 kB?
Of course, once Node18 is available from GitHub, node-fetch is no longer needed, but seems like that may take some time.
(Updated ncc because I had a build problem with node-fetch 3)