Improved Error message for missing config file #475

Gornoka · 2022-12-30T19:35:44Z

Description:
Changed error message for missing/misconfigured/misnamed config file.

Related issue:
this should help people to identify this issue quickly
Check list:

Mark if documentation changes are required.
Mark if tests were added or updated to cover the changes.

Samriel

Hello, @Gornoka!
Thank you for your contribution!
Please, resolve conflicts and consider proposed change. Then we will be happy to merge your PR.

src/labeler.ts

Co-authored-by: AndreiLobanovich <andreilobanovich@github.com>

Gornoka · 2023-06-28T21:09:40Z

thanks for the feedback, i messed up with the webui a little, pr will be open again soon

package-lock.json

MaksimZhukov · 2023-06-30T10:09:34Z

@Gornoka thank you for the contribution!

[![Mend Renovate](https://app.renovatebot.com/images/banner.svg)](https://renovatebot.com) This PR contains the following updates: | Package | Type | Update | Change | |---|---|---|---| | [actions/labeler](https://togithub.com/actions/labeler) | action | minor | `v4.2.0` -> `v4.3.0` | --- ### ⚠ Dependency Lookup Warnings ⚠ Warnings were logged while processing this repo. Please check the logs for more information. --- ### Release Notes <details> <summary>actions/labeler (actions/labeler)</summary> ### [`v4.3.0`](https://togithub.com/actions/labeler/releases/tag/v4.3.0) [Compare Source](https://togithub.com/actions/labeler/compare/v4.2.0...v4.3.0) #### What's Changed In scope of this release, the ability to specify pull request number(s) was added by [@credfeto](https://togithub.com/credfeto) in [https://github.com/actions/labeler/pull/349](https://togithub.com/actions/labeler/pull/349). Support for reading from the configuration file presented on the runner was added by [@lrstanley](https://togithub.com/lrstanley) in [https://github.com/actions/labeler/pull/394](https://togithub.com/actions/labeler/pull/394). It allows you to use a configuration file generated during workflow run or uploaded from a separate repository. Please refer to the [action documentation](https://togithub.com/actions/labeler#inputs) for more information. This release also includes the following changes: - Improved Error message for missing config file by [@Gornoka](https://togithub.com/Gornoka) in [https://github.com/actions/labeler/pull/475](https://togithub.com/actions/labeler/pull/475) - Early exit when no files are changed by [@nathanhammond](https://togithub.com/nathanhammond) in [https://github.com/actions/labeler/pull/456](https://togithub.com/actions/labeler/pull/456) - Add examples to match all repo files by [@MaksimZhukov](https://togithub.com/MaksimZhukov) in [https://github.com/actions/labeler/pull/600](https://togithub.com/actions/labeler/pull/600) - Fix a typo in the example about using the action outputs by [@MaksimZhukov](https://togithub.com/MaksimZhukov) in [https://github.com/actions/labeler/pull/606](https://togithub.com/actions/labeler/pull/606) - Bump eslint from 8.43.0 to 8.44.0 by [@dependabot](https://togithub.com/dependabot) in [https://github.com/actions/labeler/pull/601](https://togithub.com/actions/labeler/pull/601) - Bump [@typescript-eslint/parser](https://togithub.com/typescript-eslint/parser) from 5.60.1 to 5.61.0 by [@dependabot](https://togithub.com/dependabot) in [https://github.com/actions/labeler/pull/602](https://togithub.com/actions/labeler/pull/602) - Bump [@typescript-eslint/eslint-plugin](https://togithub.com/typescript-eslint/eslint-plugin) from 5.60.1 to 5.61.0 by [@dependabot](https://togithub.com/dependabot) in [https://github.com/actions/labeler/pull/604](https://togithub.com/actions/labeler/pull/604) - Bump tough-cookie from 4.1.2 to 4.1.3 by [@dependabot](https://togithub.com/dependabot) in [https://github.com/actions/labeler/pull/609](https://togithub.com/actions/labeler/pull/609) - Bump [@octokit/plugin-retry](https://togithub.com/octokit/plugin-retry) from 5.0.4 to 5.0.5 by [@MaksimZhukov](https://togithub.com/MaksimZhukov) in [https://github.com/actions/labeler/pull/610](https://togithub.com/actions/labeler/pull/610) #### New Contributors - [@credfeto](https://togithub.com/credfeto) made their first contribution in [https://github.com/actions/labeler/pull/349](https://togithub.com/actions/labeler/pull/349) - [@lrstanley](https://togithub.com/lrstanley) made their first contribution in [https://github.com/actions/labeler/pull/394](https://togithub.com/actions/labeler/pull/394) - [@nathanhammond](https://togithub.com/nathanhammond) made their first contribution in [https://github.com/actions/labeler/pull/456](https://togithub.com/actions/labeler/pull/456) **Full Changelog**: actions/labeler@v4...v4.3.0 </details> --- ### Configuration 📅 **Schedule**: Branch creation - At any time (no schedule defined), Automerge - At any time (no schedule defined). 🚦 **Automerge**: Disabled by config. Please merge this manually once you are satisfied. ♻ **Rebasing**: Whenever PR is behind base branch, or you tick the rebase/retry checkbox. 🔕 **Ignore**: Close this PR and you won't be reminded about this update again. --- - [ ] If you want to rebase/retry this PR, check this box --- This PR has been generated by [Mend Renovate](https://www.mend.io/free-developer-tools/renovate/). View repository job log [here](https://developer.mend.io/github/owntracks/android).  Co-authored-by: renovate[bot] <29139614+renovate[bot]@users.noreply.github.com>

Samriel self-requested a review June 28, 2023 15:45

Samriel self-assigned this Jun 28, 2023

Samriel suggested changes Jun 28, 2023

View reviewed changes

src/labeler.ts Outdated Show resolved Hide resolved

Gornoka closed this Jun 28, 2023

Gornoka force-pushed the error_message_for_missing_conf_rebase branch 2 times, most recently from cc660a6 to 375538a Compare June 28, 2023 20:50

Gornoka and others added 4 commits June 28, 2023 23:04

error message for missing config

856ed43

chore: formatting and index js

e927ca6

chore: update json5

a2b1669

changes from cr

f3038b8

Co-authored-by: AndreiLobanovich <andreilobanovich@github.com>

chore: recreate dist.js

fe83ad3

Gornoka reopened this Jun 28, 2023

Gornoka requested a review from a team as a code owner June 28, 2023 21:28

Gornoka requested a review from Samriel June 28, 2023 21:31

Samriel suggested changes Jun 29, 2023

View reviewed changes

package-lock.json Outdated Show resolved Hide resolved

Gornoka added 2 commits June 29, 2023 13:10

chore: revert package-lock

b2266fc

chore: newline fix

d6e8ab0

Gornoka requested a review from Samriel June 29, 2023 11:26

MaksimZhukov approved these changes Jun 30, 2023

View reviewed changes

dmitry-shibanov approved these changes Jun 30, 2023

View reviewed changes

IvanZosimov approved these changes Jun 30, 2023

View reviewed changes

Samriel approved these changes Jun 30, 2023

View reviewed changes

MaksimZhukov merged commit e3c0d9b into actions:main Jun 30, 2023

Gornoka deleted the error_message_for_missing_conf_rebase branch June 30, 2023 11:45

MaksimZhukov mentioned this pull request Jul 3, 2023

feat(config): support reading from local file if it exists #394

Merged

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Improved Error message for missing config file #475

Improved Error message for missing config file #475

Gornoka commented Dec 30, 2022

Samriel left a comment

Gornoka commented Jun 28, 2023

MaksimZhukov commented Jun 30, 2023

Improved Error message for missing config file #475

Improved Error message for missing config file #475

Conversation

Gornoka commented Dec 30, 2022

Samriel left a comment

Choose a reason for hiding this comment

Gornoka commented Jun 28, 2023

MaksimZhukov commented Jun 30, 2023