-
Notifications
You must be signed in to change notification settings - Fork 425
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
paginate over all changed files and sync and add "sync-labels" option to enable removing labels #63
Conversation
When I run 'npm run build' it adds webpack code to dist/index.js every time. It changes the js file even in main.ts is not changed.
cbae117
to
bed0dae
Compare
Nice work on the "sync-labels" feature 👍 Perhaps it is an idea to limit this PR to just that feature to increase the likelihood of it being merged? Pagination is already implemented in #43 and should probably be merged there. Doing the formatting in this PR makes it difficult to review the meaningful changes in this PR (and causes unnecessary merge conflicts). |
I can rebase this later and see if the formatting is fixed on |
Makes sense. The formatting is not yet fixed on master, but it seems you will no longer get a failing build as a result of incorrect formatting. |
The other issue is that |
I can't help you with that, could be due to a variety of reasons. But I don't think it matters much. Merge conflicts in the dist/index.js file are straightforward to resolve by the maintainers of this action and don't affect reviewing the changes, so I wouldn't worry about it. |
Thanks for this, and sorry for the huge delay. The maintainership of this action has changed a few times so some older items like this fell off the radar I merged your changes via #96 to make it a little easier / faster as Im going through and cleaning up a bit |
Build process
master
is not formatted via thenpm run format
command. I see the same changes in other open PRs so I don't think this is isolated to just me.npm run build
it adds webpack-looking wrapper code todist/index.js
every time. It changes the js file even in main.ts is not changed. I changed the build script toncc build ./src/main.ts
to compile the TypeScript source directly and it seems to work better.dist/index.js
as well so this also does not seem isolated to just me.Fixes
dist/index.js
also.Features
sync-labels: true
is given, the action will remove any labels when no matching files are modified. This closes Remove labels for reverted changes #14.