-
Notifications
You must be signed in to change notification settings - Fork 418
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Bumping actions/core and actions/github dependencies for GHES #69
Conversation
What is the benefit of changing from dist/index to lib/index? Not sure I understand the point, or why the lib/ file is so much smaller than the dist/ one... |
@dakale It's mainly to distinguish the outputs of |
Thanks, that makes sense, as does ignoring checking in lib/ |
|
This adds support for running against GHES by using v2.2.0 of
@actions/github
. I also bumped@actions/core
to 1.2.4 to fix error handling in the case anError
type is thrown rather than astring
.The build/pack steps seemed unreliable, so I updated the Typscript config to build to
./lib
, andncc
will then build out of that (this matches other actions like actions/stale).Tested by pushing this version of the action to an "actions" org on the GHES instance. I also needed to set
NODE_TLS_REJECT_UNAUTHORIZED = 0
temporarily in the action to get around my self-signed (or otherwise not trusted) server cert.