Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix #94 #95

Closed
wants to merge 2 commits into from
Closed

Fix #94 #95

wants to merge 2 commits into from

Conversation

taehwanno
Copy link

Fixes #94
Fixes #88

PTAL 😄

@dakale
Copy link
Contributor

dakale commented Sep 8, 2020

Thanks for this! I think it should be fixed now though, I took a pass earlier and updated the build/release

Its good that this was brought up. Theres a lot of work needed to improve the testing / make this action more testable / verify releases

Im not sure just npm installing locally fixes this category of issue but I need to think about it more. Generating a build as a requirement to merge changes is cumbersome because it will always have to be the most up to date, requiring work on all older PRs before they could get merged, but otherwise labeler@main wont be up to date so Im not sure what the best approach is

Thanks again though for starting the conversation, and I think this particular issue is fixed now

@dakale dakale closed this Sep 8, 2020
@taehwanno taehwanno deleted the taehwanno/update_dist branch September 9, 2020 01:34
@taehwanno
Copy link
Author

I understand your decision. thanks for your quick response :)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Need to rerun build and update main branch dist/index.js Labeler fails to execute due to typeError
2 participants