Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add Support for Linux arm64 Builds #274

Merged
merged 12 commits into from
Jun 13, 2024

Conversation

priyagupta108
Copy link
Contributor

This Pull Request introduces changes to enable building of Python packages for Linux arm64 architecture.

@priyagupta108 priyagupta108 requested a review from a team as a code owner May 15, 2024 10:08
Copy link
Contributor

@mayeut mayeut left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This PR closes #230

That being said, neither pull requests fix the issue.
Either you need to be cross building on x86_64 which would require much more changes to the builder script or you need to build on an aarch64 runner (you might have access through the private beta but as everything is private, I don't even know what's provided).
In order to test, again, you either need an aarch64 runner or update the tests scripts to run with qemu on an x86_64 runner.

@dimaqq
Copy link

dimaqq commented May 24, 2024

Gotta wait for https://github.blog/changelog/2023-10-30-accelerate-your-ci-cd-with-arm-based-hosted-runners-in-github-actions/

Should have been Q1 2024, but we don't seem to be there yet 🤔

@mayeut
Copy link
Contributor

mayeut commented Jun 1, 2024

Should have been Q1 2024, but we don't seem to be there yet

It's should be a private BETA for now so not everyone can use/see that - I know I don't - (or is it not ready ?).

At least, it seems they now do have access to some ubuntu 22.04 aarch64 runners: https://github.com/actions/python-versions/actions/runs/9254745717

@ukumar-dev
Copy link

I think it should be good to release now? We are blocked on ubuntu-arm python package too.
https://github.blog/2024-06-03-arm64-on-github-actions-powering-faster-more-efficient-build-systems/

@dimaqq
Copy link

dimaqq commented Jun 11, 2024

I got an email from GitHub about this, but IIRC arm64 builders have only been enabled for organisations and not individuals?

I’ll try to validate this.

Copy link

@dimaqq dimaqq left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The change looks good to me, though admittedly I didn't run it myself.

@atwoodjw
Copy link

I still get the following.

Error: The version '3.11' with architecture 'arm64' was not found for Ubuntu 22.04.
  The list of all available versions can be found here: https://raw.githubusercontent.com/actions/python-versions/main/versions-manifest.json

And sure enough, I still only see ARM builds for Darwin in versions-manifest.json.

Is there additional work required to use these changes and build for ubuntu/arm64?

@atwoodjw
Copy link

Ah, it looks like #289 will resolve.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

9 participants