Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix: release assets upload #285

Closed
wants to merge 1 commit into from
Closed

fix: release assets upload #285

wants to merge 1 commit into from

Commits on Jun 10, 2024

  1. fix: release assets upload 

    actions#267 introduced a regression in asset upload.

The layout of the artefacts to upload has changed. They're now all flatten in the working directory whereas before that PR, only the `hashes.sha256` file was directly in the working directory.
The change in layout caused `.toString()` to be called on python archives which corrupts the data that gets uploaded (as can be seen by comparing sha256 in `hashes.sha256` with the ones from other uploaded assets).

This commit ensures that a "flat layout" is used and that `toString()` is only called for `hashes.sha256`.
    @mayeut
    mayeut committed Jun 10, 2024
    Configuration menu
    Copy the full SHA
    907e4d8 View commit details
    Browse the repository at this point in the history