Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Implement yaml extensions overwriting the default pod/container spec #75

Merged
merged 22 commits into from
Sep 25, 2023
Merged

Implement yaml extensions overwriting the default pod/container spec #75

Show file tree
Hide file tree
Changes from 19 commits
Commits
Show all changes
22 commits
Select commit Hold shift + click to select a range
8019fad
Implement yaml extensions overwriting the default pod/container spec
nikola-jokic Apr 24, 2023
edc4f10
format files
nikola-jokic Apr 24, 2023
f49aa2d
Extend specs for container job and include docker and k8s tests in k8s
nikola-jokic Apr 25, 2023
a909ee5
Create table tests for docker tests
nikola-jokic Apr 25, 2023
5e35472
included warnings and extracted append logic as generic
nikola-jokic May 4, 2023
cdc919f
updated merge to allow for file read
nikola-jokic Aug 23, 2023
be0cc22
reverted back examples and k8s/tests
nikola-jokic Aug 23, 2023
609962f
reverted back docker tests
nikola-jokic Aug 23, 2023
2d0d20e
Tests for extension prepare-job
nikola-jokic Aug 23, 2023
e3f6653
Merge branch 'main' into nikola-jokic/yaml-extension
nikola-jokic Aug 23, 2023
c824d7e
Fix lint and format and merge error
nikola-jokic Aug 23, 2023
d17de36
Added basic test for container step
nikola-jokic Aug 24, 2023
9910332
revert hooklib since new definition for container options is received…
nikola-jokic Aug 29, 2023
e87001f
revert docker options since create options are a string
nikola-jokic Aug 29, 2023
959fa80
Fix revert
nikola-jokic Aug 29, 2023
ec354fc
Update package locks and deps
nikola-jokic Aug 31, 2023
139d44e
included example of extension.yaml. Added side-car container that was…
nikola-jokic Sep 18, 2023
78b89ce
Ignore spec modification for the service containers, change selector to
nikola-jokic Sep 22, 2023
488cc13
fix lint error
nikola-jokic Sep 25, 2023
815c21e
Add missing image override
nikola-jokic Sep 25, 2023
2403975
Add comment explaining merge object meta with job and pod
nikola-jokic Sep 25, 2023
7fffa9f
fix test
nikola-jokic Sep 25, 2023
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
30 changes: 30 additions & 0 deletions examples/extension.yaml
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -0,0 +1,30 @@
metadata:
Copy link
Contributor

@fhammerl fhammerl Sep 25, 2023 •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

NIT: comments indicating section by section if it's an 'replace' or a 'merge'?

No need if the ADR explains it

annotations:
annotated-by: "extension"
labels:
labeled-by: "extension"
spec:
securityContext:
runAsUser: 1000
runAsGroup: 3000
restartPolicy: Never
containers:
- name: $job # overwirtes job container
env:
- name: ENV1
value: "value1"
imagePullPolicy: Always
image: "busybox:1.28" # Ignored
command:
- sh
args:
- -c
- sleep 50
- name: side-car
image: "ubuntu:latest" # required
command:
- sh
args:
- -c
- sleep 60

100 changes: 59 additions & 41 deletions packages/docker/package-lock.json
View file
Open in desktop

Some generated files are not rendered by default. Learn more about how customized files appear on GitHub.

12 changes: 6 additions & 6 deletions packages/hooklib/package-lock.json
View file
Open in desktop

Some generated files are not rendered by default. Learn more about how customized files appear on GitHub.

Loading