Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Relax limitation on entrypoint allowing container actions to be executed without the entrypoint specified #77

Merged
merged 1 commit into from
Jul 17, 2023
Merged

Relax limitation on entrypoint allowing container actions to be executed without the entrypoint specified #77

merged 1 commit into from
Jul 17, 2023

Conversation

nikola-jokic
Copy link
Contributor

Fixes #76

@nikola-jokic nikola-jokic requested review from a team as code owners May 4, 2023 10:01
@nikola-jokic nikola-jokic mentioned this pull request May 25, 2023
Closed
@nikola-jokic nikola-jokic force-pushed the nikola-jokic/throw-on-container-step-no-entrypoint branch from b6399ee to a3171d6 Compare June 20, 2023 09:55
@nikola-jokic nikola-jokic force-pushed the nikola-jokic/throw-on-container-step-no-entrypoint branch from a3171d6 to 9eaacb7 Compare June 20, 2023 11:57
@nikola-jokic nikola-jokic changed the title Add limitation and throw if an entrypoint is not specified for container step Relax limitation on entrypoint allowing container actions to be executed without the entrypoint specified Jun 20, 2023
fhammerl
fhammerl approved these changes Jul 17, 2023
View reviewed changes
Copy link
Contributor

@fhammerl fhammerl left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

We no longer write the entrypoint into a sh script and execute it on the container when the step is started, instead we set it as a pod command and let it be invoked when the container is started.

This means prependPath is now unavailable in container steps - prependPath only has utility for jobContainers so this is not a breaking (or any) change.

@nikola-jokic nikola-jokic merged commit 8b83223 into main Jul 17, 2023
@nikola-jokic nikola-jokic deleted the nikola-jokic/throw-on-container-step-no-entrypoint branch July 17, 2023 09:02
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@fhammerl fhammerl fhammerl approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Using a container action requires an entrypoint to be specified
2 participants
@nikola-jokic @fhammerl