Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[all OSs] The VCPKG_ROOT variable will be removed from runner images #6376

Closed
10 tasks done
ddobranic opened this issue Oct 10, 2022 · 4 comments
Closed
10 tasks done
Assignees
Labels
Announcement awaiting-deployment Code complete; awaiting deployment and/or deployment in progress OS: macOS OS: Ubuntu OS: Windows

Comments

@ddobranic
Copy link
Contributor

ddobranic commented Oct 10, 2022

Breaking changes

The VCPKG_ROOT variable will be removed from runner images.

Target date

October, 31. The propagation will take 2-3 days.

The motivation for the changes

In accordance with the reaction of the VCPKG developers and community to the recent changes regarding the setting of the VCPKG_ROOT variable, it was decided to abandon such breaking changes so that users can independently control the contents of this environment variable.

The history of changes and reasons for cancellation can be found here: #6146, #6192, #6195, #6196.

Possible impact

Users who have already started using the VCPKG_ROOT variable in accordance with the latest changes may encounter some difficulties.

Platforms affected

  • Azure DevOps
  • GitHub Actions

Runner images affected

  • Ubuntu 18.04
  • Ubuntu 20.04
  • Ubuntu 22.04
  • macOS 10.15
  • macOS 11
  • macOS 12
  • Windows Server 2019
  • Windows Server 2022

Mitigation ways

Users who have already started using the VCPKG_ROOT variable in accordance with the latest changes should revert to using the VCPKG_INSTALLATION_ROOT variable to avoid errors.

@mikhailkoliada
Copy link
Contributor

Removal date shifted one week.

@erik-bershel erik-bershel added the awaiting-deployment Code complete; awaiting deployment and/or deployment in progress label Oct 27, 2022
FabienPean added a commit to FabienPean/VegaFEM that referenced this issue Oct 30, 2022
lstipakov added a commit to lstipakov/openvpn that referenced this issue Nov 2, 2022
By removing builin-baseline constraint, we force
vcpkg to use latest versions of ports. As a side effect,
this bumps OpenSSL to 3.0.7.

While on it, update vcpkg commit in GHA.

We also have to apply a workaround for GHA
to make it use our vcpkg checkout instead of c:\vcpkg,
see

 actions/runner-images#6376
 lukka/run-vcpkg#170

Signed-off-by: Lev Stipakov <lev@openvpn.net>
lstipakov added a commit to lstipakov/openvpn that referenced this issue Nov 2, 2022
By removing builin-baseline constraint, we force
vcpkg to use latest versions of ports. As a side effect,
this bumps OpenSSL to 3.0.7.

While on it, update vcpkg commit in GHA.

We also have to apply a workaround for GHA
to make it use our vcpkg checkout instead of c:\vcpkg,
see

 actions/runner-images#6376
 lukka/run-vcpkg#170

Signed-off-by: Lev Stipakov <lev@openvpn.net>
lstipakov added a commit to lstipakov/openvpn that referenced this issue Nov 2, 2022
By removing builin-baseline constraint, we force
vcpkg to use latest versions of ports. As a side effect,
this bumps OpenSSL to 3.0.7.

While on it, update vcpkg commit in GHA.

We also have to apply a workaround for GHA
to make it use our vcpkg checkout instead of c:\vcpkg,
see

 actions/runner-images#6376
 lukka/run-vcpkg#170

Signed-off-by: Lev Stipakov <lev@openvpn.net>
lstipakov added a commit to lstipakov/openvpn that referenced this issue Nov 2, 2022
By removing builin-baseline constraint, we force
vcpkg to use latest versions of ports. As a side effect,
this bumps OpenSSL to 3.0.7.

While on it, update vcpkg commit in GHA.

We also have to apply a workaround for GHA
to make it use our vcpkg checkout instead of c:\vcpkg,
see

 actions/runner-images#6376
 lukka/run-vcpkg#170

Signed-off-by: Lev Stipakov <lev@openvpn.net>
@monamimani
Copy link

monamimani commented Nov 5, 2022

Now that VCPKG_ROOT is not defined anymore,

For people that use the installation that comes with the image you can set VCPKG_ROOT to VCPKG_INSTALLATION_ROOT with this step.

    - name: "Set environmental variables"
      shell: bash
      run: |
        echo "VCPKG_ROOT=$VCPKG_INSTALLATION_ROOT" >> $GITHUB_ENV

cron2 pushed a commit to cron2/openvpn that referenced this issue Nov 8, 2022
By removing builin-baseline constraint, we force
vcpkg to use latest versions of ports. As a side effect,
this bumps OpenSSL to 3.0.7.

While on it, update vcpkg commit in GHA.

We also have to apply a workaround for GHA
to make it use our vcpkg checkout instead of c:\vcpkg,
see

 actions/runner-images#6376
 lukka/run-vcpkg#170

Signed-off-by: Lev Stipakov <lev@openvpn.net>
Acked-by: Gert Doering <gert@greenie.muc.de>
Message-Id: <20221102151536.255-1-lstipakov@gmail.com>
URL: https://www.mail-archive.com/openvpn-devel@lists.sourceforge.net/msg25474.html
Signed-off-by: Gert Doering <gert@greenie.muc.de>
@mikhailkoliada
Copy link
Contributor

Deployed

FabienPean added a commit to FabienPean/VegaFEM that referenced this issue Nov 27, 2022
Make the path to the vcpkg executable explicit to avoid relying on VCPKG_ROOT which had been changed (and then reverted) on github actions runners, see actions/runner-images#6376
patrikhuber added a commit to patrikhuber/eos that referenced this issue Apr 6, 2023
@mcourteaux
Copy link

This documentation:
https://github.com/actions/runner-images/blob/win22/20231023.1/images/win/Windows2022-Readme.md#environment-variables

promises an environment variable VCPKG_INSTALLATION_ROOT. However, when I try to use this in a build step like so:

- name: Configure CMake
  if: runner.os == 'Windows'
  run: cmake -S . -B ${{github.workspace}}/build -DCMAKE_BUILD_TYPE=${{env.BUILD_TYPE}} --toolchain="${{env.VCPKG_INSTALLATION_ROOT}}/scripts/buildsystems/vcpkg.cmake"

The variable seems to be not there. I tried a few variations:

  • ${{env.VCPKG_INSTALLATION_ROOT}}
  • $VCPKG_INSTALLATION_ROOT

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Announcement awaiting-deployment Code complete; awaiting deployment and/or deployment in progress OS: macOS OS: Ubuntu OS: Windows
Projects
None yet
Development

No branches or pull requests

7 participants
@monamimani @mcourteaux @mikhailkoliada @ddobranic @erik-bershel and others