Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix spaces in ndk-build.cmd path #2174

Merged
merged 2 commits into from
Dec 7, 2020
Merged

Fix spaces in ndk-build.cmd path #2174

merged 2 commits into from
Dec 7, 2020

Conversation

dsame
Copy link
Contributor

@dsame dsame commented Dec 1, 2020

Description

Bug fixing

C:\Program Files (x86)\Android\android-sdk\ndk-bundle\ndk-build.cmd

contains a line

%~dp0\build\ndk-build.cmd %*

and %~dp0 expands to a string with a spaces and causes the "Item not found" error

The PR adds the double quotes in order to make the command to work

Related issue: #1122

Check list

  • Related issue / work item is attached
  • Changes are tested and related VM images are successfully generated

@miketimofeev miketimofeev requested a review from a team December 1, 2020 10:20
@AlenaSviridenko AlenaSviridenko merged commit bcd9c6c into actions:main Dec 7, 2020
@iffy
Copy link

iffy commented Dec 8, 2020

Is this the reason I'm getting this error in my gradlew build?

...
> Task :app:javaPreCompileDebug
Note: D:\a\wiish\wiish\tests\_testtmp\wiishtest4888364\androidtest\dist\android\project\org.wiish.webviewexample\app\src\main\java\org\wiish\exampleapp\WiishActivity.java uses or overrides a deprecated API.

Note: Recompile with -Xlint:deprecation for details.
> Task :app:compileDebugJavaWithJavac


FAILURE: Build failed with an exception.
> Task :app:generateJsonModelDebug FAILED

'C:\Program' is not recognized as an internal or external command,
* What went wrong:
operable program or batch file.
Execution failed for task ':app:generateJsonModelDebug'.
...

How long until this fix is manifest in the build VM?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants