Change Android SDK root #2343
Merged
Change Android SDK root #2343
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
dsame
requested review from
vsafonkin,
al-cheb,
maxim-lobanov,
miketimofeev,
LeonidLapshin and
AlenaSviridenko
AlenaSviridenko
approved these changes
Jan 12, 2021
al-cheb
approved these changes
Jan 13, 2021
miketimofeev
approved these changes
Jan 13, 2021
MarijnS95
reviewed
Jan 13, 2021
| $sdkRoot = "C:\Android\android-sdk" | ||
| Expand-Archive -Path .\android-sdk-licenses.zip -DestinationPath $sdkInstallRoot -Force | ||
| New-Item -Path "C:\Android" -ItemType Directory | ||
| New-Item -Path "$sdkRoot" -ItemType SymbolicLink -Value "$sdkInstallRoot" |
There was a problem hiding this comment.
@dsame You mention hardlink in the PR description, but this is clearly a SymbolicLink. Shouldn't it be HardLink or Junction?
I don't know if Windows has realpath-alike functionality like UNIX but those resolve symbolic links, resulting in the path with spaces.
MarijnS95
added a commit
to MarijnS95/ndk
that referenced
this pull request
Jan 27, 2021
In [1] this hack was introduced because GH Actions virtual-environments installed the SDK in `Program Files` which includes a space, but this is not supported by the NDK. Now that the issue has been addressed [2] and the images deployed this workaround can be removed again. [1]: rust-mobile#92 [2]: actions/runner-images#2343
MarijnS95
added a commit
to MarijnS95/ndk
that referenced
this pull request
Jan 27, 2021
In [1] this hack was introduced because GH Actions virtual-environments installed the SDK in `Program Files` which includes a space, but this is not supported by the NDK. Now that the issue has been addressed [2] and the images deployed this workaround can be removed again. [1]: rust-mobile#92 [2]: actions/runner-images#2343
MarijnS95
added a commit
to MarijnS95/ndk
that referenced
this pull request
Jan 27, 2021
In [1] this hack was introduced because GH Actions virtual-environments installed the SDK in `Program Files` which includes a space, but this is not supported by the NDK. Now that the issue has been addressed [2] and the images deployed this workaround can be removed again. [1]: rust-mobile#92 [2]: actions/runner-images#2343
MarijnS95
added a commit
to rust-mobile/ndk
that referenced
this pull request
Jan 28, 2021
#118) * ci: Separate apk check and build steps An obscure one-line `apk build` failure got shadowed by a much larger deprecation warning shown by `cargo check` right above, deemed irrelevant. Separating these steps will make it clear when the issue is code-related (ndk, ndk-glue) or build-related (ndk-build, cargo-apk, cargo-subcommand). * ci: Remove Windows NDK symlink; GH images now include space-less NDK In [1] this hack was introduced because GH Actions virtual-environments installed the SDK in `Program Files` which includes a space, but this is not supported by the NDK. Now that the issue has been addressed [2] and the images deployed this workaround can be removed again. [1]: #92 [2]: actions/runner-images#2343
topjohnwu
added a commit
to topjohnwu/Magisk
that referenced
this pull request
Jan 29, 2021
rib
pushed a commit
to rust-mobile/ndk-glue
that referenced
this pull request
Dec 6, 2022
…s (#118) * ci: Separate apk check and build steps An obscure one-line `apk build` failure got shadowed by a much larger deprecation warning shown by `cargo check` right above, deemed irrelevant. Separating these steps will make it clear when the issue is code-related (ndk, ndk-glue) or build-related (ndk-build, cargo-apk, cargo-subcommand). * ci: Remove Windows NDK symlink; GH images now include space-less NDK In [1] this hack was introduced because GH Actions virtual-environments installed the SDK in `Program Files` which includes a space, but this is not supported by the NDK. Now that the issue has been addressed [2] and the images deployed this workaround can be removed again. [1]: rust-mobile/ndk#92 [2]: actions/runner-images#2343
rib
pushed a commit
to rust-mobile/ndk-context
that referenced
this pull request
Dec 7, 2022
…s (#118) * ci: Separate apk check and build steps An obscure one-line `apk build` failure got shadowed by a much larger deprecation warning shown by `cargo check` right above, deemed irrelevant. Separating these steps will make it clear when the issue is code-related (ndk, ndk-glue) or build-related (ndk-build, cargo-apk, cargo-subcommand). * ci: Remove Windows NDK symlink; GH images now include space-less NDK In [1] this hack was introduced because GH Actions virtual-environments installed the SDK in `Program Files` which includes a space, but this is not supported by the NDK. Now that the issue has been addressed [2] and the images deployed this workaround can be removed again. [1]: rust-mobile/ndk#92 [2]: actions/runner-images#2343
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Improvement
Create a hardlink
C:\Android\android-sdkpointing toC:\Program Files (x86)\Android\android-sdkand setANDROID_SDK_ROOTtoC:\Android\android-sdkProblem to solve:
ANDROID_NDK_PATH / HOME should not contain spaces. Otherwise, the script C:\Program Files (x86)\Android\android-sdk\ndk-bundle\ndk-build.cmd gives an error
changing just ndk-build.cmd is not (nearly) enough. We depend on all the compiler wrapper scripts in ./toolchains/llvm/prebuilt/windows-x86_64/bin/-clang*.cmd being capable of handling spaces, and have not gone beyond checking what else might break.
Related issue: #1122
Check list