safe_sleep function...

[mathieu-aubin]

Describe the bug
Seems like the function does achieve correct sleep times when neother sleep nor ping are present

i have taken the liberty of writing a little script showing the effects of the current code and a suggestion on how to essentially fix, under recent bash version, using SECONDS bash internal timer

the script i wrote can be found here https://0x0.st/oXL1.txt

Feel free to do whatever with this but as i said, it doesnt seem to work currently (if both ping and sleep are missing) so thats a good enough reasom to either FIX or remove useless code

Thanks!

[mathieu-aubin]

oh, thats in
src/Misc/layoutroot/run-helper.sh.template

[ruvceskistefan]

Hi @mathieu-aubin,
Thanks for filing this issue! I'm reproducing it now and I'll get back to you as soon as possible!

[mathieu-aubin]

recording of terminal running

bash <(curl -sLk https://0x0.st/oXL1.txt)

Thanks

[ruvceskistefan]

Thanks @mathieu-aubin for the very detailed description of the problem and the proposed solution! We're considering a solution so I'll probably create PR that will close this issue.

[mathieu-aubin]

I could do a PR quick but honestly, i wanted to have confirmation beforehand. If the function is useless since ANY and EVERY places runners can be installed does for sure contain sleep command, there just is no need to keep the code.

Otherwise, remove the multiple IF checks and just use the method i proposed as a "no dependency, internal solution".

SECONDS variable has been in bash for... well.. 25+ years so i think you are safe with such a solution.

[ruvceskistefan]

I created a PR that should close this issue. Thank you @mathieu-aubin for your contribution!

[ruvceskistefan]

Hi @mathieu-aubin,
Due to the feature request to use safe_sleep instead of standard sleep function in all bash scripts, I created a new PR (already merged to the main). This PR contains changes that were in the previously linked PR (just in the new bash script), as well as those additional requests. Therefore, I will close this issue. Please feel free to reopen it if you think it is necessary.
Thanks again for your contribution and suggestions!

[mathieu-aubin]

that was some complicated netting for such trivial (and problem fixing, yet only potential) addition!

Take care and keep it up!