Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Upload unfinished logs from runner when worker doesn't handle cancellation and get killed #254

Closed
TingluoHuang opened this issue Jan 2, 2020 · 0 comments
Labels
enhancement New feature or request

Comments

@TingluoHuang
Copy link
Member

Thank you 🙇‍♀ for wanting to create a feature in this repository. Before you do, please ensure you are filing the issue in the right place. Issues should only be opened on if the issue relates to code in this repository.

If you have a feature request that is relevant to this repository, the runner, then please include the information below:

Describe the enhancement

When user cancel a workflow run, the worker process has about 5 mins to response the cancellation and finish what it is doing and exit, otherwise the runner will kill the worker process.

When the process kill happen, we will lost some job/step logs since worker may not finish upload those.

It would be great if the runner can finish upload those logs, since those logs may help us to debug why the cancellation time out and what is hanging.

Code Snippet
If applicable, add a code snippet.

Additional information
Add any other context about the feature here.

NOTE: if the feature request has been agreed upon then the assignee will create an ADR. See docs/adrs/README.md

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

No branches or pull requests

1 participant