Upload unfinished job/step logs from runner on cancellation timeout #255
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
TingluoHuang
commented
Jan 2, 2020
| @@ -40,7 +39,6 @@ public override void Initialize(IHostContext hostContext) | |||
| { | |||
| base.Initialize(hostContext); | |||
| _totalLines = 0; | |||
| _pageId = Guid.NewGuid().ToString(); | |||
There was a problem hiding this comment.
we don't really need a new guid for each page, we can leverage the timeline record id for each steps, those are already unique per step.
TingluoHuang
commented
Jan 2, 2020
|
|
||
| try | ||
| { | ||
| var systemConnection = message.Resources.Endpoints.SingleOrDefault(x => string.Equals(x.Name, WellKnownServiceEndpointNames.SystemVssConnection)); |
There was a problem hiding this comment.
pull the cred from the job message, we will use this cred to talk to actions service and upload the log.
TingluoHuang
commented
Jan 2, 2020
| } | ||
|
|
||
| var record = timeline.Records.FirstOrDefault(x => x.Id == logRecordId); | ||
| if (record != null) |
There was a problem hiding this comment.
We only upload log files to timeline records for this job.
TingluoHuang
force-pushed
the
users/tihuang/logoncancel
branch
from
239f300
to
5640409
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
#254