Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fixed Post Steps order timeline #1697

Closed
wants to merge 2 commits into from

Conversation

nikola-jokic
Copy link
Contributor

Related: #1657

@nikola-jokic nikola-jokic requested a review from a team as a code owner February 18, 2022 13:24
@@ -1043,7 +1045,7 @@ private IExecutionContext CreatePostChild(string displayName, Dictionary<string,
}

var newGuid = Guid.NewGuid();
return CreateChild(newGuid, displayName, newGuid.ToString("N"), null, null, ActionRunStage.Post, intraActionState, _childTimelineRecordOrder - Root.PostJobSteps.Count, siblingScopeName: siblingScopeName);
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

add some L0 tests?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Added

@cread
Copy link

cread commented Mar 9, 2022

Is there a reason this has been closed? We've been waiting for a while for a fix for #1657 ...

@nikola-jokic
Copy link
Contributor Author

Yes, this fix was not covering all cases, so we decided to close this PR. @thboop will be implementing the entire fix so you should be expecting it soon. Thank you for showing interest @cread!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants