Issue 1739: Fixing null reference exception during configuring runner with invalid repo URL or token #1741
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…repo URL or token
| if(response.StatusCode == System.Net.HttpStatusCode.NotFound) | ||
| { | ||
| _term.WriteError("Invalid repository URL or register token"); | ||
| return StringUtil.ConvertFromJson<GitHubRunnerRegisterToken>(errorResponse); |
There was a problem hiding this comment.
ConvertFromJson will return useless data if the errorResponse is not a contract of GitHubRunnerRegisterToken
There was a problem hiding this comment.
I changed this in the new commit.
thboop
reviewed
Mar 21, 2022
| else | ||
| { | ||
| _term.WriteError($"Http response code: {response.StatusCode} from 'POST {githubApiUrl}'"); | ||
| var errorResponse = await response.Content.ReadAsStringAsync(); | ||
| _term.WriteError(errorResponse); | ||
| response.EnsureSuccessStatusCode(); | ||
|
|
There was a problem hiding this comment.
Can we just try storing the response code and using that to determine if we should throw or not.
var responseStatus = HttpStatusCode.OK;
try
{
var response = await httpClient.PostAsync(githubApiUrl, new StringContent(string.Empty));
responseStatus = response.StatusCode;
if (response.IsSuccessStatusCode)
{
Trace.Info($"Http response code: {response.StatusCode} from 'POST {githubApiUrl}'");
var jsonResponse = await response.Content.ReadAsStringAsync();
return StringUtil.ConvertFromJson<GitHubRunnerRegisterToken>(jsonResponse);
}
else
{
_term.WriteError($"Http response code: {response.StatusCode} from 'POST {githubApiUrl}'");
var errorResponse = await response.Content.ReadAsStringAsync();
_term.WriteError(errorResponse);
response.EnsureSuccessStatusCode();
}
}
catch(Exception ex) when (retryCount < 2 && responseStatus != HttpStatusCode.NotFound)
{
retryCount++;
Trace.Error($"Failed to get JIT runner token -- Atempt: {retryCount}");
Trace.Error(ex);
Trace.Info("Retrying in 5 seconds");
}
There was a problem hiding this comment.
We may want to add others to this not retry list, and looking at the response code is the easiest way to do that
There was a problem hiding this comment.
Sure, makes sense.
There was a problem hiding this comment.
I just won't trace delay time there, because it's randomly determined outside of catch.
thboop
reviewed
Mar 21, 2022
| // Something else bad happened, let's go to our retry logic | ||
| response.EnsureSuccessStatusCode(); | ||
|
|
||
| if(response.StatusCode == System.Net.HttpStatusCode.NotFound) |
AdamOlech
pushed a commit
to antmicro/runner
that referenced
this pull request
Jul 26, 2024
… with invalid repo URL or token (actions#1741) * Fixing null reference exception when configuring runner with invalid repo URL or token * Throw exception instead of ConvertFromJson * Storing the response code
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The problem was that the runner crasher with null reference exception during configuring with invalid repository URL or register token.
Closes #1739
After this change, the runner will not crash with a null reference exception but will exit with an appropriate error message.