Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Another runner code cleanup round #197

Merged
merged 7 commits into from
Dec 4, 2019
Merged

Another runner code cleanup round #197

merged 7 commits into from
Dec 4, 2019

Conversation

juliobbv
Copy link
Contributor

@juliobbv juliobbv commented Nov 13, 2019 •
edited
Loading

  • Remove remaining non-SDK references of capabilities/demands
  • Remove unused Runner.Common constants
  • Remove some unused dependencies on TFVC/Resource Utilization

@juliobbv juliobbv mentioned this pull request Nov 13, 2019
Closed
11 tasks
@juliobbv juliobbv force-pushed the users/juliobbv/anotherRunnerCleanup branch from cf40dcf to ce4d87e Compare November 13, 2019 22:09
@juliobbv juliobbv force-pushed the users/juliobbv/anotherRunnerCleanup branch from 19756b1 to 0557c60 Compare November 18, 2019 22:19
@juliobbv juliobbv changed the title [WIP] Another runner code cleanup round Another runner code cleanup round Nov 18, 2019
thboop
thboop approved these changes Nov 19, 2019
View reviewed changes
Copy link
Collaborator

@thboop thboop left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This changes look good to me! There may be other areas we can rip code out as well.

@juliobbv juliobbv force-pushed the users/juliobbv/anotherRunnerCleanup branch 2 times, most recently from 51ef021 to b2bc959 Compare November 21, 2019 03:15
@juliobbv juliobbv force-pushed the users/juliobbv/anotherRunnerCleanup branch from b2bc959 to 186f5cf Compare November 21, 2019 19:41
thboop
thboop approved these changes Nov 25, 2019
View reviewed changes
Copy link
Collaborator

@thboop thboop left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

New changes LGTM

@juliobbv juliobbv force-pushed the users/juliobbv/anotherRunnerCleanup branch from 186f5cf to 74dfa8e Compare November 27, 2019 20:46
@juliobbv juliobbv force-pushed the users/juliobbv/anotherRunnerCleanup branch from 361cc3e to 970f618 Compare December 3, 2019 22:21
@juliobbv juliobbv merged commit cd2cec8 into master Dec 4, 2019
AdamOlech pushed a commit to antmicro/runner that referenced this pull request Jan 28, 2021
@juliobbv
Another runner code cleanup round (actions#197)
25cb789 
* Remove remaining non-SDK references of capabilities/demands
* Remove unused Runner.Common constants
* Remove more variables
* Clean up RU link, and named-pipe support
* Remove NotificationSocketAddress
* Re-add legacy OnPremises JobDispatcher code (commented out)
* More misc cleanup
@toast-gear toast-gear mentioned this pull request Jun 26, 2021
Closed
@TingluoHuang TingluoHuang deleted the users/juliobbv/anotherRunnerCleanup branch September 1, 2023 20:51
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@TingluoHuang TingluoHuang TingluoHuang left review comments

@thboop thboop thboop approved these changes

@ericsciple ericsciple ericsciple approved these changes

@thechrisjohnson thechrisjohnson thechrisjohnson approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
5 participants
@juliobbv @thechrisjohnson @TingluoHuang @ericsciple @thboop