2.296.2 Release notes #2107
Merged
2.296.2 Release notes #2107
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
thboop
force-pushed
the
thboop/hotfix
branch
from
374a7e3 to
1ceed23
Compare
thboop
force-pushed
the
thboop/hotfix
branch
from
b6b210e to
e7e4f21
Compare
fhammerl
reviewed
Sep 8, 2022
| // https://docs.microsoft.com/en-us/dotnet/api/system.environment.getcommandlineargs?redirectedfrom=MSDN&view=net-6.0#remarks | ||
|
|
||
| // First, find any \ followed by a " and double the number of \ + 1. | ||
| value = Regex.Replace(value, @"(\\*)" + "\"", @"$1$1\" + "\""); |
TingluoHuang
reviewed
Sep 8, 2022
| value = Regex.Replace(value, @"(\\*)" + "\"", @"$1$1\" + "\""); | ||
| // Next, what if it ends in `\`, it would escape the end quote. So, we need to detect that at the end of the string and perform the same escape | ||
| // Luckily, we can just use the $ character with detects the end of string in regex | ||
| value = Regex.Replace(value, @"(\\+)$", @"$1$1"); |
There was a problem hiding this comment.
can we compile these regexes?
TingluoHuang
reviewed
Sep 8, 2022
| @@ -6,6 +6,9 @@ namespace GitHub.Runner.Worker.Container | |||
| { | |||
| public class DockerUtil | |||
| { | |||
| private static readonly Regex QuoteEscape = new Regex(@"(\\*)" + "\"", RegexOptions.Compiled); | |||
There was a problem hiding this comment.
Suggested change
| private static readonly Regex QuoteEscape = new Regex(@"(\\*)" + "\"", RegexOptions.Compiled); | |
| private static readonly Regex QuoteEscape = new Regex(@"(\\*)\"", RegexOptions.Compiled); |
There was a problem hiding this comment.
you can ignore me if the original way was for readability.
TingluoHuang
approved these changes
Sep 8, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Resolves #2104 and #2103