Update node external to 12.13.1 #215
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
added 3 commits
December 9, 2019 14:25
juliobbv
reviewed
Dec 9, 2019
| # TODO: Repath this blob to use a consistent version format (_ vs .) | ||
| acquireExternalTool "https://vstsagenttools.blob.core.windows.net/tools/nodejs/12_4_0/alpine/node-v${NODE12_VERSION}-alpine.tar.gz" node12_alpine | ||
| # acquireExternalTool "https://vstsagenttools.blob.core.windows.net/tools/nodejs/12.13.0/alpine/x64/node-v${NODE12_VERSION}-alpine-x64.tar.gz" node12_alpine | ||
| acquireExternalTool "https://vstsagenttools.blob.core.windows.net/tools/nodejs/${NODE12_VERSION}/alpine/x64/node-${NODE12_VERSION}-alpine-x64.tar.gz" node12_alpine |
There was a problem hiding this comment.
Is the 'v' removal in node-${NODE12_VERSION} intentional?
There was a problem hiding this comment.
Yea, this is how the file is named in the external tools blob, even though it differs from official dist download urls. Bit of an oversight on my part, but easier to change here than reconfigure the external tools
TingluoHuang
reviewed
Dec 9, 2019
TingluoHuang
reviewed
Dec 9, 2019
|
@dakale can you create an issue and link to it? |
TingluoHuang
approved these changes
Dec 12, 2019
|
This is the work for #37 |
AdamOlech
pushed a commit
to antmicro/runner
that referenced
this pull request
Jan 28, 2021
* Update node external to 12.13.1 * Typo * Typo2
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Bumps external node runtime to 12.13.1 / latest LTS