Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Delete un-used code. #218

Merged
merged 1 commit into from
Dec 16, 2019
Merged

Delete un-used code. #218

merged 1 commit into from
Dec 16, 2019

Conversation

TingluoHuang
Copy link
Member

@TingluoHuang TingluoHuang commented Dec 11, 2019 •
edited
Loading

#121

Deleting...

  • AAD auth provider
  • PAT auth provider
  • LocalRun
  • Cert manager
  • Cred store
  • DT.Expression V1
  • DT.Pipeline contract for orchestration
  • DT.Webapi contract for legacy stuff
  • DT.Contract
  • CoreWebApi
  • Unused VssCredentials (windows, basic, service identity)

E2E tested:

  • Windows
  • macOS
  • Linux

@TingluoHuang TingluoHuang changed the title Delete un-used code. [WIP] Delete un-used code. Dec 11, 2019
@TingluoHuang TingluoHuang force-pushed the users/tihuang/deleteunusedcodev1 branch from 31bd372 to 3ea3b5f Compare December 12, 2019 19:05
juliobbv
juliobbv approved these changes Dec 13, 2019
View reviewed changes
Copy link
Contributor

@juliobbv juliobbv left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

PR LGTM!

@TingluoHuang TingluoHuang force-pushed the users/tihuang/deleteunusedcodev1 branch 5 times, most recently from 917ac8c to 15342f6 Compare December 16, 2019 16:33
@TingluoHuang TingluoHuang changed the title [WIP] Delete un-used code. Delete un-used code. Dec 16, 2019
juliobbv
juliobbv reviewed Dec 16, 2019
View reviewed changes
src/Test/L0/Listener/CommandSettingsL0.cs
Constants.Runner.CommandLine.Args.Password, // argName
"What is your GitHub password?", // description
Constants.Runner.CommandLine.Args.Token, // argName
"What is your runner register token?", // description
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

How about: What is your runner registration token?

@juliobbv
Copy link
Contributor

@TingluoHuang new changes LGTM as well. Left you some minor comments. 📝

@juliobbv juliobbv mentioned this pull request Dec 16, 2019
Closed
11 tasks
@TingluoHuang TingluoHuang force-pushed the users/tihuang/deleteunusedcodev1 branch from 15342f6 to e34e550 Compare December 16, 2019 20:29
@TingluoHuang TingluoHuang merged commit d0a4a41 into master Dec 16, 2019
@TingluoHuang TingluoHuang deleted the users/tihuang/deleteunusedcodev1 branch December 16, 2019 22:05
AdamOlech pushed a commit to antmicro/runner that referenced this pull request Jan 28, 2021
@TingluoHuang
delete un-used code. (actions#218)
bd08721
@rockandska rockandska mentioned this pull request Mar 20, 2021
Closed
@snyk-bot snyk-bot mentioned this pull request Jun 21, 2022
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@juliobbv juliobbv juliobbv approved these changes

@ericsciple ericsciple Awaiting requested review from ericsciple

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@TingluoHuang @juliobbv