Clean up error messages for container scenarios

[dakale]

• @TingluoHuang
  cc @juliobbv Since you are also doing some cleanup work

Do either of you have opinions on changing some of these #if directives to plain c#? I think in general its more readable, and lets us remove a few specific cases of #pragma warning disable CS1998 where we are suppressing a warning only introduced because of the directives. Its also useful for when you are building on eg Windows, and may accidentally have some compile error in a !OS_WINDOWS block that only fails during CI. Similarly, the intellisense / finding references stuff seems to work better without the directives because it can find references to code made from inside those directive blocks, eg a reference to a function that is only called on linux and you are developing on windows or vice versa

On the other hand, I think it will generate a slightly larger assembly (looks like with these changes, the layout dir is ~1-2kb larger, which is probably negligible, and may also be due to other reasons), it will add an extra if check at runtime, but its just comparing static values and might get optimized out anyways (but could still be the source of a bug or error), and is a bit more verbose

Just wanted to get some early feedback before I finish the rest of this, totally fine sticking with the existing pattern of using directives for platform specific behavior

[TingluoHuang]

How would you handle the following case?

#if OS_WINDOWS
    [ServiceLocator(Default = typeof(RSAEncryptedFileKeyManager))]
#else
    [ServiceLocator(Default = typeof(RSAFileKeyManager))]
#endif
    public interface IRSAKeyManager : IRunnerService
    { ... }

[dakale]

Not sure. Im not proposing changing it everywhere though, just reducing the usage. I might change it back as I work on this if I dont find more specific areas where it would be useful

[TingluoHuang]

I am fine with it either way, go play with it and make a decision. 😄

[dakale]

Will merge by EOD but ready for explicit review, I dont think Ill add anything else here for now. Keeping the non-directive logic in places in functions that return Tasks, to avoid warnings about async logic only on certain platforms