Setting debug using GitHub Action variables #2234
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
TingluoHuang
approved these changes
Oct 28, 2022
nikola-jokic
pushed a commit
to nikola-jokic/runner
that referenced
this pull request
May 12, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What
This PR adds support to set debug variables using GitHub Action Variables which are available in
varscontext.Why
Currently, debug variables(
ACTIONS_STEP_DEBUGandACTIONS_RUNNER_DEBUG) are being set using secrets. Since they are secrets, the value is not displayed in UI. With the introduction of plain text variables, it would be easier for users to manage their debug logging using variables.How
Before setting global variables we add the debug variables from
varscontext in case they are not already present in the request message.The precedence is given to variable in the agent request message which is passed using secrets. So if a repo has
ACTIONS_STEP_DEBUGsecret asfalseand the same variable astrue. We will considerACTIONS_STEP_DEBUGto befalsehttps://github.com/github/c2c-actions-ace/issues/167