Bring back "tools folder" fallback code #232
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
thboop
reviewed
Dec 17, 2019
src/Runner.Common/HostContext.cs
Outdated
| path = Environment.GetEnvironmentVariable("RUNNER_TOOL_CACHE") ?? | ||
| // The following fall-back can be removed once Hosted macOS images | ||
| // properly set the RUNNER_TOOL_CACHE environment variable | ||
| Environment.GetEnvironmentVariable("AGENT_TOOLSDIRECTORY"); |
There was a problem hiding this comment.
This isn't a complete revert, lets make sure to test this in R0 before rolling out to the other rings
There was a problem hiding this comment.
Agreed. Let's do the complete revert in this block of code. I thought it checked a few vars before ...
There was a problem hiding this comment.
This isn't the correct fix. We need to set to /Users/runner/hostedtoolcache
Which is set by the $RUNNER_TOOL_CACHE variable. We should just do the full revert imo
$AGENT_TOOLSDIRECTORY is empty on OSX
There was a problem hiding this comment.
The block has been completely reverted now.
thboop
requested changes
Dec 17, 2019
juliobbv
force-pushed
the
users/juliobbv/bringBackFallback
branch
from
e61bbb3
to
148eccc
Compare
juliobbv
added a commit
that referenced
this pull request
Dec 17, 2019
juliobbv
added a commit
that referenced
this pull request
Dec 18, 2019
* Bring back tools folder fallback code (#232) * Prepare 2.163.1 runner release
AdamOlech
pushed a commit
to antmicro/runner
that referenced
this pull request
Jan 28, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.