Verify that Windows runner service has started successfully #236
Conversation
| try | ||
| { | ||
| _term.WriteLine("Waiting for service to start..."); | ||
| service.WaitForStatus(ServiceControllerStatus.Running, TimeSpan.FromSeconds(60)); |
There was a problem hiding this comment.
60 seconds seems super long to start a service. Is there any reason it would take more then 15?
There was a problem hiding this comment.
I think we can afford the timeout to be intentionally conservative. On my machine, the service usually takes ~1s/2s to run, but then I'm using a machine with an NVMe SSD with tons of RAM, but a machine with an HDD that's happening to be in the process of paging during that precise config moment may take at least an order of magnitude longer, and create a false positive that could result in an issue getting filed.
There was a problem hiding this comment.
2 minutes used to be the default timeout for stopping windows services (maybe starting too?)
with a sluggish machine on startup things can be slow
There was a problem hiding this comment.
Also we've seen some surprisingly slow cloud machines cause timeouts in unit tests just launching simple processes. I've had to bump test timeouts from 10s to 20s before, and that's for a machine that has already finished booting up.
There was a problem hiding this comment.
Yeah, Eric's experience with process launching on slow machines has been my experience as well. There are some environments that are just really slow, and we can't control them.
I'll keep the timeout as it currently is, but we can change it later if we desire so.
Before this change, the runner was sending the command to start the runner, but it never verified that the service had actually started successfully. Now it waits for a successful
Runningstatus.Fixes #194