Formalize TryUpdateDisplayName and EvaluateDisplayName as members of interface IStep
#2374
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jww3
commented
Jan 16, 2023
Comment on lines
+24
to
+25
| bool TryUpdateDisplayName(out bool updated); | ||
| bool EvaluateDisplayName(DictionaryContextData contextData, IExecutionContext context, out bool updated); |
There was a problem hiding this comment.
I co-located these in the IStep interface because I strongly suspect the latter can be eliminated in a second pass refactor. Having them side-by-side should make that refactor easier to reason about.
fhammerl
approved these changes
Jan 20, 2023
ashb
pushed a commit
to ashb/runner
that referenced
this pull request
Feb 7, 2023
…ated. (actions#2313) * Defer evaluation of a step's DisplayName until its condition is evaluated. * Formalize TryUpdateDisplayName and EvaluateDisplayName as members of interface `IStep` (actions#2374)
nikola-jokic
pushed a commit
to nikola-jokic/runner
that referenced
this pull request
May 12, 2023
…ated. (actions#2313) * Defer evaluation of a step's DisplayName until its condition is evaluated. * Formalize TryUpdateDisplayName and EvaluateDisplayName as members of interface `IStep` (actions#2374)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
based on a conversation with @fhammerl regarding #2313