Change runner image to make user/folder align with ubuntu-latest hosted runner. #2469
Conversation
| RUN adduser --disabled-password --gecos "" --uid 1001 runner \ | ||
| && groupadd docker --gid 123 \ |
There was a problem hiding this comment.
Do we want to extract those as ARGs? Is there ever a scenario where we'll want to change those at build time?
There was a problem hiding this comment.
I will change it to ARG once we need to. 😄
| RUN apt-get update -y \ | ||
| && apt-get install -y --no-install-recommends \ | ||
| sudo \ | ||
| && rm -rf /var/lib/apt/lists/* |
There was a problem hiding this comment.
I'm thinking out loud here, do we have a need for the ca-certificates package to be installed?
There was a problem hiding this comment.
Seems like a reasonable thing to do.
There was a problem hiding this comment.
the dotnet base image we use already installed ca-certificates
https://github.com/dotnet/dotnet-docker/blob/main/src/runtime-deps/6.0/bullseye-slim/amd64/Dockerfile
There was a problem hiding this comment.
We will avoid git for now, since that will require us to patch the image every time git has a security patch.
/home/runner/run.sh/home/runner/_worksudoto the image, and make userrunneras passwordless sudoers/home/runneris owned byrunner:docker (1001:123)