Add update certificates to ./run.sh if RUNNER_UPDATE_CA_CERTS env is set #2471
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
TingluoHuang
reviewed
Mar 3, 2023
TingluoHuang
reviewed
Mar 3, 2023
Link-
reviewed
Mar 6, 2023
TingluoHuang
reviewed
Mar 6, 2023
TingluoHuang
reviewed
Mar 6, 2023
TingluoHuang
reviewed
Mar 6, 2023
TingluoHuang
reviewed
Mar 7, 2023
…nvvar that will update certs
Link-
reviewed
Mar 8, 2023
Link-
reviewed
Mar 8, 2023
Co-authored-by: Bassem Dghaidi <568794+Link-@users.noreply.github.com>
Link-
reviewed
Mar 8, 2023
Co-authored-by: Bassem Dghaidi <568794+Link-@users.noreply.github.com>
Co-authored-by: Bassem Dghaidi <568794+Link-@users.noreply.github.com>
TingluoHuang
reviewed
Mar 8, 2023
nikola-jokic
changed the title
Co-authored-by: Tingluo Huang <tingluohuang@github.com>
TingluoHuang
reviewed
Mar 8, 2023
TingluoHuang
reviewed
Mar 8, 2023
TingluoHuang
reviewed
Mar 8, 2023
Co-authored-by: Tingluo Huang <tingluohuang@github.com>
TingluoHuang
reviewed
Mar 8, 2023
TingluoHuang
approved these changes
Mar 8, 2023
nikola-jokic
added a commit
to nikola-jokic/runner
that referenced
this pull request
May 12, 2023
…set (actions#2471) * Included entrypoint that will update certs and run ./run.sh * update ca if RUNNER_UPDATE_CA env is set * changed env variable to RUNNER_UPDATE_TRUST_STORE * moved entrypoint to be run.sh, removed Dockerfile entrypoint, added envvar that will update certs * Update src/Misc/layoutroot/run.sh Co-authored-by: Bassem Dghaidi <568794+Link-@users.noreply.github.com> * Update src/Misc/layoutroot/run.sh Co-authored-by: Bassem Dghaidi <568794+Link-@users.noreply.github.com> * Update src/Misc/layoutroot/run.sh Co-authored-by: Bassem Dghaidi <568794+Link-@users.noreply.github.com> * Update src/Misc/layoutroot/run.sh Co-authored-by: Tingluo Huang <tingluohuang@github.com> * Update src/Misc/layoutroot/run.sh Co-authored-by: Tingluo Huang <tingluohuang@github.com> * removed doc comment on func --------- Co-authored-by: Bassem Dghaidi <568794+Link-@users.noreply.github.com> Co-authored-by: Tingluo Huang <tingluohuang@github.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
When certificates are injected, the image should call update certificates before starting the runner.
If env
RUNNER_UPDATE_CA_CERTSis set, therun.shwill try updating certificates before starting the runner