Add orchestrationId to useragent for better correlation. #2568
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
TingluoHuang
commented
Apr 26, 2023
| @@ -42,6 +43,13 @@ public async Task<TaskResult> RunAsync(AgentJobRequestMessage message, Cancellat | |||
| DateTime jobStartTimeUtc = DateTime.UtcNow; | |||
| IRunnerService server = null; | |||
|
|
|||
| // add orchestration id to useragent for better correlation. | |||
| if (message.Variables.TryGetValue(Constants.Variables.System.OrchestrationId, out VariableValue orchestrationId) && | |||
There was a problem hiding this comment.
I still need to do a server PR to add the variable to the job message.
cory-miller
previously approved these changes
Apr 26, 2023
cory-miller
approved these changes
Apr 26, 2023
nikola-jokic
pushed a commit
to nikola-jokic/runner
that referenced
this pull request
May 12, 2023
* Add orchestrationId to useragent for better correlation. * .
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
With
OrchestrationIdin the user-agent, we can get a better correlation in our telemetry to figure out the source of each HTTP request (runner+job).