Clarify details for defaults, shell, and working-dir #607
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
In this commit, I clarify some details for our implementation of shell and working-dir (cc: @ericsciple )
ericsciple
reviewed
Jul 21, 2020
ericsciple
reviewed
Jul 21, 2020
ericsciple
reviewed
Jul 21, 2020
ericsciple
approved these changes
Jul 22, 2020
fabianishere
pushed a commit
to fabianishere/runner
that referenced
this pull request
Aug 24, 2020
fabianishere
pushed a commit
to fabianishere/runner
that referenced
this pull request
Sep 23, 2020
AdamOlech
pushed a commit
to antmicro/runner
that referenced
this pull request
Jan 28, 2021
TingluoHuang
pushed a commit
that referenced
this pull request
Apr 21, 2021
roryabraham
reviewed
Jun 30, 2022
|
|
||
| The composite action author will be required to set the `shell` and `workingDir` of the composite action. Moreover, the composite action author will be able to explicitly set the shell for each composite run step. The workflow author will not have the ability to change these attributes. | ||
| ### Shell and Working-directory | ||
| For each run step in a composite action, the action author can set the `shell` and `working-directory` attributes for that step. These attributes are optional for each run step - by default, the `shell` is set to whatever default value is associated with the runner os (ex: bash =\> Mac). Moreover, the composite action author can map in values from the `inputs` for it's `shell` and `working-directory` attributes at the step level for an action. |
There was a problem hiding this comment.
These attributes are optional for each run step - by default, the
shellis set to whatever default value is associated with the runner os
This doesn't appear to be true. Removing the shell attribute from any run step of a composite action results in:
The template is not valid ... Required property is missing: shell
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
In this commit, I clarify some details for our implementation of shell and working-dir (cc: @ericsciple )