Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

V2 setup-dotnet ADR #208

Closed
wants to merge 4 commits into from
Closed

V2 setup-dotnet ADR #208

wants to merge 4 commits into from

Conversation

vsafonkin
Copy link

@vsafonkin vsafonkin commented Jun 21, 2021

This PR outlines the basic proposals for the v2 version of setup-dotnet.

Internal issue: 1807

comment:

To summarize the current behavior for .NET team review

We have a bunch of .NET Core versions pre-installed on images. And the problem is that action works very inconsistent on different platforms.

  • Ubuntu:
    Pre-installed location (where .NET is pre-installed): “/usr/share/dotnet”
    Action installs to: “/home/runner/.dotnet”
  • Windows:
    Pre-installed location: “C:\Program Files\dotnet”
    Action installs to “C:\Users\runneradmin\AppData\Local\Microsoft\dotnet”
  • MacOS:
    Pre-installed location: “/Users/runner/.dotnet”
    Action installs to “/Users/runner/.dotnet”

How it works currently on macOS

Pre-installed location and action location are the same. It means that if we have versions 2.1.x, 3.1.x and 5.0.x pre-installed on image and user will install 3.1 via action, installation will be skipped because version already exists. if customer runs dotnet --version it will report version 5.x if customer doesn't have global.json (because both 2.1, 3.1, 5.0 will be located in the same folder and dotnet will choose the latest one based on https://docs.microsoft.com/en-us/dotnet/core/versions/selection)

How it works currently on Windows / Ubuntu

Pre-installed location and action location are different. It means if we have versions 2.1.x, 3.1.x and 5.0.x pre-installed on image and user will install 3.1 via action, version 3.1 will be installed to the separate location and dotnet --version will report version 3.1 because it is the single version installed in that location.

Problems

Behavior is inconsistent between platforms and it confuses users
macOS users complain that dotnet still uses 5.x despite the fact that they invoked action with 3.1
Windows / Ubuntu users complain that pre-installed .NET are not consumed and it is always installed that takes build time
In our understand, the correct behavior is on macOS right now.
The new versions should be installed in the same location like pre-installed. It is expected behavior that dotnet --version will point the latest one and we should just point customers to documentation.

@Rhinowiwina

This comment has been minimized.

@Rhinowiwina

This comment has been minimized.

@Rhinowiwina

This comment has been minimized.

@Rhinowiwina

This comment has been minimized.

@Rhinowiwina

This comment has been minimized.

@mattjohnsonpint
Copy link

mattjohnsonpint commented Apr 29, 2022

So... v2 released Feb 25, 2022. Was none of this addressed? Is this for v3 now?

@vsafonkin
Copy link
Author

@mattjohnsonpint, thanks! Re-create this PR because I have lost the branch v-vlsafo/adr-v2-doc in my fork.
New PR: #291

@vsafonkin vsafonkin closed this Apr 29, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants