-
Notifications
You must be signed in to change notification settings - Fork 476
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Allow c-style comments in global.json #257
Conversation
Initial commit was from Windows: lots of EOL trouble + differences in index.js. |
@vsafonkin
I don't know how to fix that. My local |
I have no idea where |
New info: it is the This means the current master probably will not even build itself. I don't think fixing this should be part of this pull request. Can you fix master so we can all rebase our failing pull requests on a new and working baseline? This is also the problem with PR #250. |
@vsafonkin Done |
Just ran into this issue in a new repo, any chance of getting this merged soon? |
@xt0rted EDIT: I force-pushed after a rebase onto main. Should be mergable again. |
.NET SDK 6.0.300 no longer allows comments in |
Description:
Allow c-style comments in
global.json
.Related issue:
Implements #254
Check list: