Add support for Windows-arm #320
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
IvanZosimov
reviewed
Sep 16, 2022
Co-authored-by: Ivan <98037481+IvanZosimov@users.noreply.github.com>
IvanZosimov
approved these changes
Sep 22, 2022
marko-zivic-93
approved these changes
Sep 22, 2022
e-korolevskii
approved these changes
Sep 23, 2022
vsafonkin
approved these changes
Sep 26, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description:
This PR fixes an issue where older versions of powershell (powershell versus pwsh (powershell core) is used on windows. Due to that, the
install-dotnetscript fails to detect it is on a windows arm device, and installs the x64 version of dotnet.So now we try to use powershell core if it exists, then fallback to powershell. This should not impact linux/mac os in any way.
Related issue:
Add link to the related issue.
Check list: