Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description:
Refactoring was conducted only for installer.ts module. The most significant changes are in
DotnetCoreInstaller
class:DotnetInstallDir
classDotnetInstallScript
class, which now allows to invoke install-script multiple times and conditionally apply script arguments.Example of
DotnetInstallScript
class usage (just an example code, not how it is actually set here)The script preparation is conducted upon calling the constructor and all platform-specific arguments are inserted by default
Related issue:
Related but does not solve #387, just conducts necessary preparations for further fix. Should be treated as general refactoring.
Check list: