-
Notifications
You must be signed in to change notification settings - Fork 531
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Fix extractor selection on windows #141
Fix extractor selection on windows #141
Conversation
e11891a
to
bba6fe1
Compare
Here is a demo repo to demonstrate the problem: https://github.com/paulcacheux/poc-setup-go-demo |
Friendly ping, maybe @joshmgross |
👋 Hey @paulcacheux, thanks for the ping. I'll find a team to review and release this bug fix. |
The job that is failing seems to be unrelated to the changes. To fix it I think another PR updating the node dependencies would be needed in my opinion. Happy to help if needed |
Hi @paulcacheux, I agree with you on
I created #144 where I fixed those issues with the developpement of a new feature |
This fix should now be available in https://github.com/actions/setup-go/releases/tag/v2.1.4, and |
Awesome, thank you ! |
Great to see this. 💯 Would have saved me 20 minutes today if it was on |
On Windows the extractor uses
tar
instead ofzip
because the code is usingos.arch()
(which returns the arch like x64 or arm64) instead ofos.platform()
.This PR fixes this problem.