Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

docs: go-version-file for other use cases #295

Open
wants to merge 7 commits into
base: main
Choose a base branch
from

Conversation

v1v
Copy link

@v1v v1v commented Nov 30, 2022

Description:

Update the docs to reflect the use case for the go-version-file: .go-version that I've just found it was implemented in #62

Related issue:
Add link to the related issue.

Check list:

  • Mark if documentation changes are required.
  • Mark if tests were added or updated to cover the changes.

@v1v v1v requested a review from a team November 30, 2022 10:47
v1v added a commit to v1v/beats that referenced this pull request Nov 30, 2022
v1v added a commit to v1v/elastic-agent that referenced this pull request Nov 30, 2022
v1v added a commit to v1v/fleet-server that referenced this pull request Nov 30, 2022
v1v added a commit to v1v/elastic-agent-shipper that referenced this pull request Nov 30, 2022
v1v added a commit to v1v/apm-server that referenced this pull request Nov 30, 2022
v1v added a commit to v1v/cloudbeat that referenced this pull request Nov 30, 2022
README.md Outdated Show resolved Hide resolved
v1v added a commit to elastic/fleet-server that referenced this pull request Nov 30, 2022
v1v added a commit to elastic/beats that referenced this pull request Nov 30, 2022
v1v added a commit to elastic/elastic-agent that referenced this pull request Nov 30, 2022
v1v added a commit to elastic/elastic-agent-shipper that referenced this pull request Nov 30, 2022
mergify bot pushed a commit to elastic/beats that referenced this pull request Nov 30, 2022
v1v added a commit to elastic/apm-server that referenced this pull request Nov 30, 2022
mergify bot pushed a commit to elastic/beats that referenced this pull request Nov 30, 2022
mergify bot pushed a commit to elastic/beats that referenced this pull request Nov 30, 2022
mergify bot pushed a commit to elastic/fleet-server that referenced this pull request Nov 30, 2022
see actions/setup-go#295

(cherry picked from commit cf5c762)

# Conflicts:
#	.github/workflows/golangci-lint.yml
mergify bot pushed a commit to elastic/fleet-server that referenced this pull request Nov 30, 2022
mergify bot pushed a commit to elastic/fleet-server that referenced this pull request Nov 30, 2022
mergify bot pushed a commit to elastic/elastic-agent that referenced this pull request Nov 30, 2022
mergify bot pushed a commit to elastic/elastic-agent that referenced this pull request Nov 30, 2022
mergify bot pushed a commit to elastic/elastic-agent-shipper that referenced this pull request Nov 30, 2022
v1v added a commit to elastic/elastic-agent that referenced this pull request Nov 30, 2022
see actions/setup-go#295

(cherry picked from commit 3d8e3c7)

Co-authored-by: Victor Martinez <victormartinezrubio@gmail.com>
v1v added a commit to elastic/elastic-agent that referenced this pull request Nov 30, 2022
see actions/setup-go#295

(cherry picked from commit 3d8e3c7)

Co-authored-by: Victor Martinez <victormartinezrubio@gmail.com>
v1v added a commit to elastic/fleet-server that referenced this pull request Nov 30, 2022
see actions/setup-go#295

(cherry picked from commit cf5c762)

Co-authored-by: Victor Martinez <victormartinezrubio@gmail.com>
v1v added a commit to elastic/fleet-server that referenced this pull request Nov 30, 2022
see actions/setup-go#295

(cherry picked from commit cf5c762)

Co-authored-by: Victor Martinez <victormartinezrubio@gmail.com>
v1v added a commit to elastic/beats that referenced this pull request Nov 30, 2022
see actions/setup-go#295

(cherry picked from commit 0105608)

Co-authored-by: Victor Martinez <victormartinezrubio@gmail.com>
v1v added a commit to elastic/beats that referenced this pull request Nov 30, 2022
see actions/setup-go#295

(cherry picked from commit 0105608)

Co-authored-by: Victor Martinez <victormartinezrubio@gmail.com>
v1v added a commit to elastic/beats that referenced this pull request Nov 30, 2022
see actions/setup-go#295

(cherry picked from commit 0105608)

Co-authored-by: Victor Martinez <victormartinezrubio@gmail.com>
v1v added a commit to elastic/apm-server that referenced this pull request Nov 30, 2022
see actions/setup-go#295

(cherry picked from commit 1ccbb4a)

Co-authored-by: Victor Martinez <victormartinezrubio@gmail.com>
v1v added a commit to elastic/apm-server that referenced this pull request Nov 30, 2022
see actions/setup-go#295

(cherry picked from commit 1ccbb4a)

Co-authored-by: Victor Martinez <victormartinezrubio@gmail.com>
v1v added a commit to elastic/elastic-agent-shipper that referenced this pull request Nov 30, 2022
see actions/setup-go#295

(cherry picked from commit d0393ab)

Co-authored-by: Victor Martinez <victormartinezrubio@gmail.com>
v1v added a commit to elastic/elastic-agent-shipper that referenced this pull request Nov 30, 2022
see actions/setup-go#295

(cherry picked from commit d0393ab)

Co-authored-by: Victor Martinez <victormartinezrubio@gmail.com>
axw pushed a commit to elastic/apm-server that referenced this pull request Dec 1, 2022
see actions/setup-go#295

(cherry picked from commit 1ccbb4a)

Co-authored-by: Victor Martinez <victormartinezrubio@gmail.com>
README.md Outdated

### If the go.mod file

The `go-version-file` input accepts a path to a `go.mod` file or a `go.work` file that contains the version of Go to be used by a project. As the `go.mod` file contains only major and minor (e.g. 1.18) tags, the action will follow the above-mentioned approach.

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Could be useful to mention the go-version output here

go-version:

as it makes it easier to know what go version was resolved to from the go.mod file

Copy link
Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

See fde5dd2

chrisberkhout pushed a commit to elastic/beats that referenced this pull request Jun 1, 2023
@dsame dsame added documentation Improvements or additions to documentation investigation The issue is under investigation and removed investigation The issue is under investigation labels Aug 3, 2023
@dsame
Copy link
Contributor

dsame commented Aug 11, 2023

Hello @v1v , can you please add the use case added in #402 ?

@dsame dsame self-assigned this Aug 14, 2023
@dsame dsame linked an issue Aug 15, 2023 that may be closed by this pull request
…sion

* upstream/main: (47 commits)
  Fix Install on Windows is very slow (actions#393)
  Bump word-wrap from 1.2.3 to 1.2.4
  Fix licensing for Semver 6.3.1
  Rebuild after updating Semver
  Bump semver from 6.3.0 to 6.3.1
  Bump tough-cookie and @azure/ms-rest-js (actions#392)
  Limit to Linux only
  Add imageOS to primaryKey
  Add note about YAML parsing versions (actions#382)
  Added a description that go-version should be specified as a string type (actions#367)
  Update action.yml (actions#379)
  Move eslint-plugin-node to dev dependencies
  Install eslint-plugin-node
  Update configuration files
  Bump @actions/cache dependency to v3.2.1 (actions#374)
  Update xml2js (actions#370)
  Fix glob bug in package.json scripts section (actions#359)
  update README fo v4 (actions#354)
  Update configuration files (actions#348)
  Add Go bin if go-version input is empty (actions#351)
  ...
@v1v v1v requested a review from a team as a code owner August 15, 2023 12:26
@v1v
Copy link
Author

v1v commented Aug 15, 2023

Can you please add the use case added in #402 ?

See 721bdf3

@dsame
Copy link
Contributor

dsame commented Aug 16, 2023

The merging is blocked by the merging either #402 or #376 PRs

@dsame dsame self-requested a review August 16, 2023 08:37
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
documentation Improvements or additions to documentation
Projects
None yet
Development

Successfully merging this pull request may close these issues.

feat: Utilize the.tool-versions file to set expected Go version
3 participants