Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add support for Eclipse Temurin #191

Closed
giltene opened this issue Jul 10, 2021 · 5 comments
Closed

Add support for Eclipse Temurin #191

giltene opened this issue Jul 10, 2021 · 5 comments
Labels
feature request New feature or request to improve the current logic

Comments

@giltene
Copy link
Contributor

giltene commented Jul 10, 2021

With Eclipse Temurin expected to come out with a July update release for various OpenJDK versions, it would be good to add Temurin as a distribution option in action/setup-java ASAP. The obvious spelling would probably be "temurin", alongside the existing distribution options of "adopt" and "zulu".
@giltene giltene added feature request New feature or request to improve the current logic needs triage labels Jul 10, 2021
@josephjthomas
Copy link

+1 for OP. Since July, all releases are deployed to Adoptium instead of AdoptOpenJDK. That means, if you specify adopt and version 16 in your workflow, you get 16.0.1+9, but 16.0.2+7 is the newest version. The workflow actively provides outdated Java versions.

joschi added a commit to joschi/setup-java that referenced this issue Aug 1, 2021
@joschi
Add support for Adoptium OpenJDK
4a8552d 
Refs actions#191
@joschi joschi mentioned this issue Aug 1, 2021
Merged
2 tasks
maxim-lobanov added a commit that referenced this issue Aug 6, 2021
@joschi @maxim-lobanov
Add support for Eclipse Temurin (#201)
4b1b3d4 
* Add support for Adoptium OpenJDK

Refs #191

* Rename distribution to Eclipse Temurin

* Update end-to-end tests in GitHub workflows

* Exclude e2e tests for Temurin JREs for now

* fix version

* Update e2e-versions.yml

* Handle Eclipse Temurin version suffixes ("beta")

* Add test for new version suffix "beta"

* Add updated `index.js`

* fix an issue

Co-authored-by: Maxim Lobanov <maxim-lobanov@github.com>
@maxim-lobanov
Copy link
Contributor

PR with changes has been merged (thank you @joschi for great contribution).
We will release new task version on Monday because we are trying to avoid Friday releases.

@msgilligan
Copy link

setup-java@main with distribution: 'temurin' is working for me -- thanks!

@MaksimZhukov
Copy link
Contributor

Hello everyone!
We've released a new version (v2.2.0) of setup-java action and updated the major tag accordingly.
Link to the release: https://github.com/actions/setup-java/releases/tag/v2.2.0
Thanks!

@MaksimZhukov
Copy link
Contributor

I'm closing the issue. Feel free to contact us if you have any questions.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
feature request New feature or request to improve the current logic
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
6 participants
@msgilligan @giltene @maxim-lobanov @dmitry-shibanov @MaksimZhukov @josephjthomas