Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Failing to execute correct node file #538

Closed
2 of 5 tasks
Gabe-Ambrosio opened this issue Jul 11, 2022 · 12 comments
Closed
2 of 5 tasks

Failing to execute correct node file #538

Gabe-Ambrosio opened this issue Jul 11, 2022 · 12 comments
Assignees
Labels
bug Something isn't working

Comments

@Gabe-Ambrosio
Copy link

Gabe-Ambrosio commented Jul 11, 2022

Description:
When this action is run on actions/setup-node@v3.4.0 it fails to execute node with:

/usr/local/bin/docker exec  825742ed8cb56497af43a3e9cad45d62a8173d83a0d7ee04089e4661011a3157 sh -c "cat /etc/*release | grep ^ID"
Attempting to download [14](https://github.com/Soluto-Private/trailhead/runs/7286847871?check_suite_focus=true#step:4:15)...
Acquiring 14.20.0 - x64 from https://github.com/actions/node-versions/releases/download/14.20.0-2633808318/node-14.20.0-linux-x64.tar.gz
Extracting ...
/bin/tar xz --strip 1 -C /__w/_temp/522c4b56-fe91-4c39-9441-4326bea08743 -f /__w/_temp/21d5041b-557e-46ea-9bd6-d39a79fcc807
Adding to the cache ...
Done
/__t/node/14.[20](https://github.com/Soluto-Private/trailhead/runs/7286847871?check_suite_focus=true#step:4:21).0/x64/bin/node --version
Error: There was an error when attempting to execute the process '/__t/node/14.20.0/x64/bin/node'. This may indicate the process failed to start. Error: spawn /__t/node/14.20.0/x64/bin/node ENOENT

Action version:
actions/setup-node@v3.4.0

Platform:

  • Ubuntu
  • macOS
  • Windows

Runner type:

  • Hosted
  • Self-hosted

Tools version:

yarn v1.22.19
node 14.20.0

Repro steps:
Adding an action with:

- name: Use Node.js 14.x
  uses: actions/setup-node@v3
  with:
    node-version: 14

Will trigger the issue.

Expected behavior:
I expect the install to succeed without any errors.

Actual behavior:
The installation fails when it tries to execute the node executable, specifically running the command:

node --version

Edit:
It also looks like this is only occurring with the docker container:

image: node:14-alpine
@Gabe-Ambrosio Gabe-Ambrosio added bug Something isn't working needs triage labels Jul 11, 2022
@funkswing
Copy link

funkswing commented Jul 11, 2022

I had this issue as well (image: node:16.14.2-alpine3.15)

Setting uses: actions/setup-node@v3.3.0 fixed it. This is obviously a temporary fix until the issue is resolved.

@vsafonkin
Copy link

Hi @Gabe-Ambrosio, we will take a look at this, thanks for your report.

@dmitry-shibanov
Copy link
Contributor

Hello everyone. The issue comes from these lines. Internally it uses spawn method to execute it. But toolcache node versions are not compatible with alpine that is why the command getting error on the process level and it produces the issue. We prepared a pull request to fix it #540. But as temporary workaround for alpine images you can remove node-version input, because it does not affect installed node version.

@Gabe-Ambrosio
Copy link
Author

Hi @vsafonkin , I just wanted to say thank you for the prompt response and for your team's help in fixing the issue!

@dmitry-shibanov dmitry-shibanov self-assigned this Jul 12, 2022
@dmitry-shibanov
Copy link
Contributor

Hello @Gabe-Ambrosio. The fix was merged to the main branch. Could you please confirm that it works as expected ?

@Gabe-Ambrosio
Copy link
Author

Hello @Gabe-Ambrosio. The fix was merged to the main branch. Could you please confirm that it works as expected ?

Hi @dmitry-shibanov , yep it looks like that fixed it! And just to be sure, I pinned the latest commit SHA when I used the action like this:

- name: Use Node.js 14.x
  uses: actions/setup-node@2fddd8803e2f5c9604345a0b591c3020ee971a93
    with:
      node-version: 14

And it successfully setup node without a problem with this output:

Run actions/setup-node@2fddd8803e2f5c9604345a0b591c3020ee971a93
/usr/local/bin/docker exec  6b581d163bdf8c99a8f935c359b51a9a294e3928da5ddd9bf9ea3c24b7a6a1e7 sh -c "cat /etc/*release | grep ^ID"
Attempting to download [14](https://github.com/XXX)
Acquiring 14.20.0 - x64 from https://github.com/actions/node-versions/releases/download/14.20.0-2633808318/node-14.20.0-linux-x64.tar.gz
Extracting ...
/bin/tar xz --strip 1 -C /__w/_temp/5d6c264f-35cd-45f0-ba3e-01f3a78641f9 -f /__w/_temp/c8b62606-4a[15]
Adding to the cache ...
Done

@dmitry-shibanov
Copy link
Contributor

Hello @Gabe-Ambrosio. Thank you for response. I'll prefer to keep the issue open until new release.

@dgaubert
Copy link

@dmitry-shibanov, do you have an ETA for the release?

Thanks in advance for maintaining it.

@dmitry-shibanov
Copy link
Contributor

Hello everyone. We released a new version and updated the major tag with fix. Could you please confirm that everything works as expected ?

@dgaubert
Copy link

I can confirm the new release fixed the issue. Many thanks for the quick hot-fix!

@Aleksanderdir
Copy link

Aleksanderdir commented Jul 15, 2022 via email

@dmitry-shibanov
Copy link
Contributor

Hello @dgaubert. Thank you for your response.

For now I'm going to close the issue. If you have any concerns feel free to ping us.

deining pushed a commit to deining/setup-node that referenced this issue Nov 9, 2023
Bumps [typescript](https://github.com/Microsoft/TypeScript) from 5.1.6 to 5.2.2.
- [Release notes](https://github.com/Microsoft/TypeScript/releases)
- [Commits](microsoft/TypeScript@v5.1.6...v5.2.2)

---
updated-dependencies:
- dependency-name: typescript
  dependency-type: direct:development
  update-type: version-update:semver-minor
...

Signed-off-by: dependabot[bot] <support@github.com>
Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

No branches or pull requests

6 participants