Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Azure DevOps Artifacts support for registry-url #746

Open
wants to merge 5 commits into
base: main
Choose a base branch
from

Conversation

tylerjwatson
Copy link

Description:
actions/setup-node does not support Azure DevOps Artifacts even though DevOps is also a Microsoft product. This is because actions/setup-node configures a temporary .npmrc file with an _authToken syntax, but AzureDevops requires npm's :username, ":_password", and ":email" syntax.

This patch adds support for Azure DevOps, and other registries by adding a username action input parameter. When this is input is set, the .npmrc file will be written with a :username, :_password and :email instead of an :_authToken.

Fetching private scoped packages from Azure DevOps Artifacts is now supported and working with this patch.

Related issue:
N/A

Check list:

  • Mark if documentation changes are required.
  • Mark if tests were added or updated to cover the changes.

@erdenerrallas19
Copy link

?

@andyleejordan
Copy link

Omg, this needs to be merged. I just spent a day and half hitting my head against my desk unable to get my GitHub Workflows to use my ADO feed (even though I was able to configure Dependabot, on GitHub just fine) only to finally realize the ADO feed requires username/password, not an auth token. And that's not supported (yet). Can't just put it in my .npmrc because then local builds break.

This has been open a year...@dmitry-shibanov can you please review and release this addition? Thank you!

@@ -25,6 +25,8 @@ inputs:
description: 'Used to specify a package manager for caching in the default directory. Supported values: npm, yarn, pnpm.'
cache-dependency-path:
description: 'Used to specify the path to a dependency file: package-lock.json, yarn.lock, etc. Supports wildcards or a list of file names for caching multiple dependencies.'
username:

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think I would suggest adding an explicit password value too, instead of doubling up on authToken as they are very much not one and the same.

@andyfisher100
Copy link

andyfisher100 commented Aug 29, 2024

This is a must have for this action in my opinion. Until Github Packages has more investment thrown behind it to add support for more packages types that Azure DevOps has, we will be confined to using Azure DevOps Overall

Can this please be worked on and merged? @dmitry-shibanov it seems this needs a review as suggested by @andyleejordan?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants