-
Notifications
You must be signed in to change notification settings - Fork 584
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Pip upgrade notice is passed as an error to the workflow summary #809
Comments
Hello @t3chguy |
We see the same error report after upgrading to We install the |
|
As a temporary fix we added environment variable
|
This is a follow up commit to my previous commit [1], which upgraded GitHub Actions runner for macOS builds to 'macos-14' (#868). While we still support Python 3.9 to build Mozc on macOS environment, currently we cannot use 'setup-python' to set up Python 3.9 in 'macos-14' runner [2]. Also we don't use 'setup-python' in other platforms such as Windows build. For simplicity, let's just use the default python in the runner [3], which is Python 3.11 as of writing. Then we should no longer see errors from 'setup-python' in the build summary [4]. #codehealth [1]: 4af1a44 [2]: actions/setup-python#808 [3]: https://github.com/actions/virtual-environments/blob/main/images/macos/macos-14-Readme.md [4]: actions/setup-python#809 PiperOrigin-RevId: 604223079
|
Hi @t3chguy , The notice which is there in logs of set up python is generating the error messaging in workflow summary. The setup-python action checks for a pip update as part of its process,The actions/setup-python GitHub Action does not check the pip update on all operating systems. The behavior you're seeing is specific to the macOS environment. On macOS, the action checks for the pip update and notifies you if a newer version is available. The notice is not an error, but an informational message from the actions/setup-python. As long as your workflow is functioning as expected, you can safely ignore this notice. It's just informing you that a newer version of pip is available. If you have a step in your workflow to upgrade pip, then the latest version should be in use despite this message. And only for python version 3.10 notice message is visible . For versions 3.12 and 3.11 this notice message is not visible. |
But why is the action creating an error? GitHub Action also supports warning and even better notice messages. See the documentation here: https://docs.github.com/en/actions/using-workflows/workflow-commands-for-github-actions#setting-a-notice-message Independent of a pipeline failing or not, the emitted message level to the pipeline summary is just wrong. |
@gowridurgad, even though it can be safely ignored, which is alright – it should still be flagged as a warning, not an error. |
Hi, The notice is simply an informational message from pip stating that a newer version of pip is available. The action has already upgraded pip to version 24.0 as part of the setup process. The notice is displayed because the pip command that checks for updates is still run after the upgrade, and pip is not immediately aware that it has been updated. If you don't want to see this message, you could add an environment variable PIP_DISABLE_PIP_VERSION_CHECK=1 to your workflow to disable the version check that pip performs. However, this won't impact the functionality of your workflow. |
Thanks for your comment, @gowridurgad. Yes, this does not impact the functionality of the workflow at all, and is indeed an informational message from |
- disable pip version check to avoid annotation errors (see actions/setup-python#809)
- disable pip version check to avoid annotation errors (see actions/setup-python#809) - replace deprecated set-ouput command
- disable pip version check to avoid annotation errors (see actions/setup-python#809)
- disable pip version check to avoid annotation errors (see actions/setup-python#809)
Hi @t3chguy , The issue is now resloved and we are no longer encountering the error message for macos-14/macos-latest. Attached a screenshot for your reference. could you please verify this on your end and confirm? |
I can confirm this is no longer happening for me. Thanks |
Seems to be related to actions/setup-python#809.
Description:
A not up to date pip is installed and an error generated based on the Notice in the logs
This should wholly be a warning like the other similar one below in the screenshot.
Action version:
Specify the action version
Platform:
Runner type:
Tools version:
Python 3.12
Pip 23.2.1
Repro steps:
A description with steps to reproduce the issue. If your have a public example or repo to share, please provide the link.
https://github.com/element-hq/element-desktop/actions/runs/7725494597/job/21060231622#step:6:43
Expected behavior:
Either an up to date pip is installed or the Notice should generate a warning, not an error
Actual behavior:
An alarming error is produced
The text was updated successfully, but these errors were encountered: