Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Revise isGhes logic #963

Merged
merged 4 commits into from
Oct 21, 2024
Merged

Revise isGhes logic #963

merged 4 commits into from
Oct 21, 2024

Conversation

jww3
Copy link
Contributor

@jww3 jww3 commented Oct 18, 2024 •
edited
Loading

Description:
I'm fixing the logic within helper method isGhes to ensure that it doesn't misrecognize GitHub Enterprise Cloud instances as GHES instances.

Related issue:
https://github.com/newsroom/press-releases/data-residency-in-the-eu

Check list:

  • Mark if documentation changes are required.
  • Mark if tests were added or updated to cover the changes.

@jww3 jww3 marked this pull request as ready for review October 18, 2024 16:19
@jww3 jww3 requested a review from a team as a code owner October 18, 2024 16:19
@HarithaVattikuti HarithaVattikuti merged commit f4c5a11 into main Oct 21, 2024
258 checks passed
@HarithaVattikuti HarithaVattikuti deleted the jww3-isghes-fix branch October 21, 2024 16:42
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@easyt easyt easyt approved these changes

@aparnajyothi-y aparnajyothi-y aparnajyothi-y approved these changes

@priya-kinthali priya-kinthali priya-kinthali approved these changes

@priyagupta108 priyagupta108 priyagupta108 approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
6 participants
@jww3 @easyt @aparnajyothi-y @priya-kinthali @priyagupta108 @HarithaVattikuti